Skip to content

Dev 9385 make contactdetails identifiable#234

Merged
charlta merged 3 commits into
mainfrom
DEV-9385-make-contactdetails-identifiable
Jul 13, 2026
Merged

Dev 9385 make contactdetails identifiable#234
charlta merged 3 commits into
mainfrom
DEV-9385-make-contactdetails-identifiable

Conversation

@Boris-Filin

Copy link
Copy Markdown
Contributor

Description

Make ContactDetails inherit Identifiable. Change ContactDetails.id to a deprecated alias for the mrid field. Update tests accordingly.

Note: data representations such as XML have not been changed, otherwise all of the previous saves would break. This can be fixed at a later date.

Associated tasks

JVM parity:

Test Steps

Run tests - they have been updated to use mrid.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

Boris Filin added 2 commits July 13, 2026 12:26
Signed-off-by: Boris Filin <boris.filin@zepben.com>
Signed-off-by: Boris Filin <boris.filin@zepben.com>

Signed-off-by: Boris Filin <boris.filin@zepben.com>
@Boris-Filin
Boris-Filin marked this pull request as ready for review July 13, 2026 04:57
@Boris-Filin
Boris-Filin requested a review from charlta July 13, 2026 04:57
Comment thread src/zepben/ewb/model/cim/extensions/iec61968/common/contact_details.py Outdated
Comment thread changelog.md Outdated
Signed-off-by: Boris Filin <boris.filin@zepben.com>
@Boris-Filin
Boris-Filin requested a review from charlta July 13, 2026 05:58
@charlta
charlta merged commit 9d4dcf2 into main Jul 13, 2026
8 checks passed
@charlta
charlta deleted the DEV-9385-make-contactdetails-identifiable branch July 13, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants