Skip to content

DEV-9690 Ensure all backfill fields are @property; Mark their setters as depre…#237

Merged
charlta merged 1 commit into
mainfrom
DEV-9690-backref-props
Jul 22, 2026
Merged

DEV-9690 Ensure all backfill fields are @property; Mark their setters as depre…#237
charlta merged 1 commit into
mainfrom
DEV-9690-backref-props

Conversation

@Boris-Filin

Copy link
Copy Markdown
Contributor

Description

Ensure all backfill fields are @Property; Mark their setters as depre…
If you have added new dependencies to the project please state why.

Associated tasks

None

Test Steps

Run tests

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • [ ] I have updated the changelog.
  • [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

Screenshots

…cated

Signed-off-by: Boris Filin <boris.filin@zepben.com>
Comment thread src/zepben/ewb/model/cim/iec61970/base/core/feeder.py
Comment thread src/zepben/ewb/model/cim/iec61970/base/core/feeder.py
Comment thread src/zepben/ewb/model/cim/iec61970/base/core/feeder.py
@Boris-Filin
Boris-Filin marked this pull request as ready for review July 21, 2026 04:38
@Boris-Filin
Boris-Filin requested review from charlta and chestm007 July 21, 2026 04:38

@chestm007 chestm007 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor formatting issues - will be resolved when i fix the linter running as part of workflows.

@power_electronics_connection.setter
@deprecated("power_electronics_connection should never be set directly - it is automatically set when adding it to the `phases` list")
def power_electronics_connection(self, value):
self._power_electronics_connection = value No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky you have been given a free pass on

Image

@charlta
charlta merged commit 182e142 into main Jul 22, 2026
9 checks passed
@charlta
charlta deleted the DEV-9690-backref-props branch July 22, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants