DEV-9690 Ensure all backfill fields are @property; Mark their setters as depre…#237
Merged
Conversation
…cated Signed-off-by: Boris Filin <boris.filin@zepben.com>
Boris-Filin
commented
Jul 21, 2026
Boris-Filin
commented
Jul 21, 2026
Boris-Filin
commented
Jul 21, 2026
Boris-Filin
commented
Jul 21, 2026
Boris-Filin
marked this pull request as ready for review
July 21, 2026 04:38
chestm007
approved these changes
Jul 21, 2026
chestm007
left a comment
Contributor
There was a problem hiding this comment.
some minor formatting issues - will be resolved when i fix the linter running as part of workflows.
charlta
reviewed
Jul 22, 2026
| @power_electronics_connection.setter | ||
| @deprecated("power_electronics_connection should never be set directly - it is automatically set when adding it to the `phases` list") | ||
| def power_electronics_connection(self, value): | ||
| self._power_electronics_connection = value No newline at end of file |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Ensure all backfill fields are @Property; Mark their setters as depre…
If you have added new dependencies to the project please state why.
Associated tasks
None
Test Steps
Run tests
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
[ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.Security
When developing applications, use following guidelines for information security considerations:
Documentation
[ ] I have updated the changelog.[ ] I have updated any documentation required for these changes.Breaking Changes
Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.
Screenshots