integrate Slog into logx#327
Open
JiChenSSG wants to merge 6 commits into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
5 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings
Comment on lines
+58
to
+65
| func toSlogFields(fields ...logx.LogField) []interface{} { | ||
| slogFields := make([]interface{}, 0, len(fields) * 2) | ||
| for _, field := range fields { | ||
| slogFields = append(slogFields, field.Key, field.Value) | ||
| } | ||
|
|
||
| return slogFields | ||
| } |
There was a problem hiding this comment.
style: toSlogFields creates a new slice for each call. Consider using a pool for better performance in high-volume logging scenarios.
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#325
Greptile Summary
This pull request integrates the new log/slog package from Go 1.21 into the logx module of the zero-contrib project, implementing a SlogWriter struct in logx/slogx/slog.go to adapt the logx.Writer interface for slog usage.
logx/slogx/slog.gofor consistent formatting across all types in log messagestoSlogFieldsfunction to create a single slice for all fields, improving efficiencySlogWriterstruct with methods for various log levels (Debug, Error, Info, etc.) using slogNewSlogWriterfunction to create a newlogx.Writerinstance using slog.Handler