Add Cline harness over its native ACP server (cline --acp) - #237
Open
jhonoryza wants to merge 4 commits into
Open
Add Cline harness over its native ACP server (cline --acp)#237jhonoryza wants to merge 4 commits into
jhonoryza wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #236
Summary
Adds Cline (open-source coding agent, npm
cline, Apache-2.0) as a harness, driven over its native ACP server —cline --acp— via a newAcpAgentSpecon the sharedAcpHarness(same shape as Grok/Hermes/Pi). No new driver; no engine/sync/doc-crate changes.HarnessId::Cline(proto, serde kebab-case →"cline", additive + wire-compatible)cline_spec(): executablecline, args["--acp"], env overrideCLINE_EXECUTABLE, TurnBoundary steering, reasoning ladder Minimal..XHigh mapped from the CLI's--thinking(degrades to agent default — no config option advertised), fallback "Cline default" model, 30s prompt stall boundcli_name, brand iconcline-mark, picker + accounts icons) +ZERON_HARNESS=clinecline_spec_runs_the_same_fixture_turn(existing fake-ACP harness)docs/research/cline-harness.md,docs/research/cline-harness-tasks.md)Verified against the real CLI (3.0.60, live probe — details in the doc)
session/promptsettles deterministically withstopReason: "end_turn"(4.1s trivial turn)modelscatalog + plan/actmodesonsession/new; zeron's picker gets the real catalogconfigOptionsare provider + model only — approvals always arrive assession/request_permissionand bridge to zeron's approval UI (deliberately NOT launching with--auto-approve true)session/loadresume confirmed (replays prior conversation;mcpServersrequired)_metanull) → turn-boundary steering, as spec'dpromptCapabilities.image: true→ attachments map to image content blocksTesting
cargo check --workspacecleancargo test -p zeron-harnessgreen (incl. new cline fixture test)cargo test -p zeron-engine registrygreencargo clippy— no new warnings from this change (remaining warnings are pre-existing in untouched files)cline --acp: handshake → session/new → session/prompt → cross-process session/load + follow-up turnKnown follow-up
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.