Rework model selector with loadout-backed slots - #356
Draft
senxd wants to merge 11 commits into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
# Conflicts: # crates/ui/src/composer.rs # crates/ui/src/motion.rs # crates/ui/src/pickers.rs # crates/ui/src/settings.rs # crates/ui/src/settings/shortcuts.rs # crates/ui/src/shell.rs
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
The reset button's job is better served by jumping to the Model Loadout settings page, and the traits tray painted a second hairline under the tab row's own bottom border. Also switches the loadouts tab glyph to a star and lands the remaining upstream-merge adaptations (draft options now live in defaults, test call sites updated). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
Also this was not listed above but the Pi provider in the model selector respects the model filter that is set in the Pi config. It should accurately represent what /models looks like in the pi cli. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some("")disables a slot shortcut whileNonekeeps the positionalmod-shift-Ndefaultprovider_ordermodel[1m]idempotently via a sharedmodel_argumenthelper; picker rows show each row's resolved loadout shortcut badgeloadout/{bindings,cards,catalog,indicator,options}.rsand add extensive unit + gpui tests (shortcut normalization, reorder semantics, menu navigation, macOS shifted-digit aliases)Screenshots
Test plan
cargo check --workspace --all-targetscargo test -p zeron-ui loadout(67 tests)cargo fmt --checkCmd+Shift+1-5defaults still workGenerated with Devin