Added Support For Storage Site API's#2206
Conversation
|
coverage: 77.373%. first build — storagesite into master |
vontedduchaithra
force-pushed
the
storagesite
branch
from
9a771ee to
f655fe4
Compare
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
vontedduchaithra
force-pushed
the
storagesite
branch
from
f655fe4 to
bfe26c0
Compare
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
| @@ -0,0 +1,294 @@ | |||
| # Copyright 2025 IBM Corp. All Rights Reserved. | |||
There was a problem hiding this comment.
Please change the copyright year to the current year.
|
|
||
| # Resource properties that are supported as filter query parameters. | ||
| query_props = [ | ||
| 'cpc-uris', |
There was a problem hiding this comment.
The query parameter for the cpc-uris property is named cpc-uri.
So far, the assumption in the code is that the property has the same name as the query parameter.
That is not the case here, so you need to add special handling of that to the code, and also make sure there is a testcase for that case. The property name here should probably remain cpc-uris because that will be the property that is specified in the filter_args parameter of list(). The special handling is probably in _list_with_operation() or in divide_filter_args(), but these are very generic methods/functions and you don't want to hard code that case there. I think it requires some more class variable in the StorageSiteManager object to provide the necessary data to these functions. You need to work out how you want to handle that, and we can discuss it in the weekly meeting.
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
3 participants
No description provided.