Skip to content

Update coreutils-version to 9.12 from 9.11 - #116

Open
zosopentoolsmain wants to merge 2 commits into
mainfrom
bump-coreutils-version-9.12
Open

zosopentoolsmain wants to merge 2 commits into
mainfrom
bump-coreutils-version-9.12

Conversation

@zosopentoolsmain

Copy link
Copy Markdown
Contributor

No description provided.

@collinfunk

Copy link
Copy Markdown

Hey! I co-maintain GNU coreutils for context. We made a quoting change to 'env' and 'printenv' which were a bit too aggressive. A large part of the rationale was improved robustness, avoiding applications getting confused with environment variables that may have newlines or other strange characters. Here is the old behavior:

$ env -i ENV='hello'$'\n''FAKE_ENV=goodbye' env
ENV=hello
FAKE_ENV=goodbye

Here is the new behavior, making it clear that FAKE_ENV is not an environment variable:

$ env -i ENV='hello'$'\n''FAKE_ENV=goodbye' ~/.local/bin/env
ENV='hello'$'\n''FAKE_ENV=goodbye'

However, this caused some issues that we did not foresee from our scanning of Debian Code Search [1] [2].

I suggest applying a patch that we commited post-release, making this quoting only occur when standard output is not a terminal: https://github.com/coreutils/coreutils/commit/782a1e5b.patch

Apologies for the extra work, but I figured it was worth giving a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants