Skip to content

Honor ZOPEN_INSTALL_MINIMAL in zopen-build install command generation - #1252

Merged
sachintu47 merged 1 commit into
mainfrom
copilot/update-zopen-install-minimal
Sep 18, 2026
Merged

sachintu47 merged 1 commit into
mainfrom
copilot/update-zopen-install-minimal

Conversation

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Content Update

Category

  • zopen build framework
  • zopen package manager
  • Documentation
  • CI/CD
  • Tools

Description

bin/zopen-build documented ZOPEN_INSTALL_MINIMAL behavior by convention, but the normal install path did not honor it when constructing ZOPEN_INSTALL_CMD. This updates install command generation so default behavior stays unchanged while minimal mode drops inline compiler/linker assignments and relies on the exported environment instead.

  • Install command behavior

    • preserve the current non-CMake, non-skip default by appending ${ZOPEN_EXTRA_INSTALL_CC_OPTS} when ZOPEN_INSTALL_MINIMAL is unset
    • explicitly set ZOPEN_INSTALL_MINIMAL=no in that default/full path
    • when ZOPEN_INSTALL_MINIMAL is set, build ZOPEN_INSTALL_CMD without inline CC / CPPFLAGS / CFLAGS / CXX / CXXFLAGS / LDFLAGS assignments
  • Scope control

    • leave CMake install handling unchanged
    • leave skip install handling unchanged
  • Help text

    • add ZOPEN_INSTALL_MINIMAL alongside the other *_MINIMAL environment settings in zopen-build -h
  • Regression coverage

    • add focused tests for:
      • default/full install command generation
      • minimal install command generation
      • help text presence for ZOPEN_INSTALL_MINIMAL
# default/full path
ZOPEN_INSTALL_CMD="\"${ZOPEN_INSTALL}\" ${ZOPEN_INSTALL_OPTS} ${verboseOpts} ${ZOPEN_EXTRA_INSTALL_CC_OPTS}"
ZOPEN_INSTALL_MINIMAL="no"

# minimal path
ZOPEN_INSTALL_CMD="\"${ZOPEN_INSTALL}\" ${ZOPEN_INSTALL_OPTS}"
ZOPEN_INSTALL_MINIMAL="yes"

Related Issues

  • Related Issue #

[optional] Are there any post-deployment tasks or follow-up actions required?

None.

Copilot AI lite review requested due to automatic review settings September 18, 2026 06:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Isolate the default test environment variable and update the published reference documentation.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread tools/test_zopen_build.py Outdated

def _run_resolve_commands(self, install_minimal=None):
with tempfile.TemporaryDirectory() as temp_dir:
install_minimal_line = ""
Copilot AI review requested due to automatic review settings September 18, 2026 06:40
Copilot AI changed the title [WIP] Update zopen-build to honor ZOPEN_INSTALL_MINIMAL variable Honor ZOPEN_INSTALL_MINIMAL in zopen-build install command generation Sep 18, 2026
Copilot AI requested a review from sachintu47 September 18, 2026 06:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Fix the test’s environment isolation and clarify the full set of variables omitted in minimal mode.

Review details

Suppressed comments (1)

tools/test_zopen_build.py:93

  • The default-path test inherits ZOPEN_INSTALL_MINIMAL from the process environment, so a runner that happens to export this variable will exercise the minimal branch instead of the advertised default/unset branch and can fail spuriously (or stop detecting a regression in the full path). Unset it in the generated shell script before applying the optional test value.
                {install_minimal_line}
  • Files reviewed: 1/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Co-authored-by: sachintu47 <32639496+sachintu47@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 18, 2026 10:48
@sachintu47
sachintu47 force-pushed the copilot/update-zopen-install-minimal branch from 118da7c to 75760c7 Compare September 18, 2026 10:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@sachintu47
sachintu47 marked this pull request as ready for review September 18, 2026 10:49
@sachintu47
sachintu47 merged commit f8c21d3 into main Sep 18, 2026
2 of 3 checks passed
@sachintu47
sachintu47 deleted the copilot/update-zopen-install-minimal branch September 18, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants