Honor ZOPEN_INSTALL_MINIMAL in zopen-build install command generation - #1252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Isolate the default test environment variable and update the published reference documentation.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
|
|
||
| def _run_resolve_commands(self, install_minimal=None): | ||
| with tempfile.TemporaryDirectory() as temp_dir: | ||
| install_minimal_line = "" |
Copilot
AI
changed the title
[WIP] Update zopen-build to honor ZOPEN_INSTALL_MINIMAL variable
Honor Sep 18, 2026
ZOPEN_INSTALL_MINIMAL in zopen-build install command generation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Fix the test’s environment isolation and clarify the full set of variables omitted in minimal mode.
Review details
Suppressed comments (1)
tools/test_zopen_build.py:93
- The default-path test inherits
ZOPEN_INSTALL_MINIMALfrom the process environment, so a runner that happens to export this variable will exercise the minimal branch instead of the advertised default/unset branch and can fail spuriously (or stop detecting a regression in the full path). Unset it in the generated shell script before applying the optional test value.
{install_minimal_line}
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Co-authored-by: sachintu47 <32639496+sachintu47@users.noreply.github.com>
sachintu47
force-pushed
the
copilot/update-zopen-install-minimal
branch
from
September 18, 2026 10:48
118da7c to
75760c7
Compare
sachintu47
approved these changes
Sep 18, 2026
sachintu47
marked this pull request as ready for review
September 18, 2026 10:49
sachintu47
requested review from
DevonianTeuchter,
HarithaIBM,
IgorTodorovskiIBM,
MikeFultonDev and
v1gnesh
as code owners
September 18, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Category
Description
bin/zopen-builddocumentedZOPEN_INSTALL_MINIMALbehavior by convention, but the normal install path did not honor it when constructingZOPEN_INSTALL_CMD. This updates install command generation so default behavior stays unchanged while minimal mode drops inline compiler/linker assignments and relies on the exported environment instead.Install command behavior
skipdefault by appending${ZOPEN_EXTRA_INSTALL_CC_OPTS}whenZOPEN_INSTALL_MINIMALis unsetZOPEN_INSTALL_MINIMAL=noin that default/full pathZOPEN_INSTALL_MINIMALis set, buildZOPEN_INSTALL_CMDwithout inlineCC/CPPFLAGS/CFLAGS/CXX/CXXFLAGS/LDFLAGSassignmentsScope control
skipinstall handling unchangedHelp text
ZOPEN_INSTALL_MINIMALalongside the other*_MINIMALenvironment settings inzopen-build -hRegression coverage
ZOPEN_INSTALL_MINIMALRelated Issues
[optional] Are there any post-deployment tasks or follow-up actions required?
None.