Added time durations for DND tooltip. Fixes #561#1502
Open
Paperyduke6 wants to merge 1 commit intozulip:mainfrom
Open
Added time durations for DND tooltip. Fixes #561#1502Paperyduke6 wants to merge 1 commit intozulip:mainfrom
Paperyduke6 wants to merge 1 commit intozulip:mainfrom
Conversation
Paperyduke6
force-pushed
the
update-dnd-timer
branch
from
9b154f4 to
b8b1108
Compare
Paperyduke6
force-pushed
the
update-dnd-timer
branch
from
b8b1108 to
ce11cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #561
This PR picks up the work from #1419 and addresses the outstanding issues to bring it to a mergeable state.
Changes from #1419:
Moved checkDndExpirationOnStartup inside the dom-ready handler, the previous implementation called it before the renderer was ready, causing the IPC message to silently fail on startup
Moved the mouseleave listener outside the $dndButton click handler, previously a new listener was registered on every click, requiring multiple clicks to close the dropdown after repeated use
Fixed a config leak where cancelling "Until I resume" DND would leave dndExpiration persisted in the config indefinitely — removeConfigItem now always runs when DND is turned off regardless of whether a timeout exists
Added event.stopPropagation() to dropdown item click handlers to prevent clicks bubbling up to the $dndButton handler and re-toggling the dropdown immediately
Updated CSS to .dnd-dropdown and .dnd-dropdown-item classes rather than bare div selectors
Tested on: Windows
Screen Capture
DND.tooltip.update.mp4