Skip to content

Added new pre commit hook for automating the error tables generation - #5

Merged
emilianomaccaferri merged 3 commits into
mainfrom
4-automate-stringtables-generation-when-errortables-changes
Jul 30, 2026
Merged

Added new pre commit hook for automating the error tables generation#5
emilianomaccaferri merged 3 commits into
mainfrom
4-automate-stringtables-generation-when-errortables-changes

Conversation

@MaryB25

@MaryB25 MaryB25 commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Brief description
Considering the ideas listed by @Ale32 , I decided to investigate all the possibilities.

  • A pre-commit hook that fails if:
    • An ErrorTables CSV is changed but not the StringTables one.
    • A StringTable CSV is changed but not the ErrorTables one.
    • Both folders are modified, but the application of the script on ErrorFolder does not generate the actual StringTables one.
  • The pre-commit runs in a CI job, making the whole pipeline fail if the pre-commit fails.

@MaryB25 MaryB25 self-assigned this Jul 27, 2026
@MaryB25 MaryB25 linked an issue Jul 27, 2026 that may be closed by this pull request

@emilianomaccaferri emilianomaccaferri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @galeone

@galeone

galeone commented Jul 29, 2026

Copy link
Copy Markdown
Member

@emilianomaccaferri merge and bump the version committing on main branch + create a release

@MaryB25
MaryB25 requested review from mcilloni and removed request for Ale32 July 29, 2026 11:57

@mcilloni mcilloni left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilianomaccaferri
emilianomaccaferri merged commit e84316e into main Jul 30, 2026
8 checks passed
@MaryB25
MaryB25 deleted the 4-automate-stringtables-generation-when-errortables-changes branch July 30, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate StringTables generation when ErrorTables changes

4 participants