Add regression tests for HD-map chopping, plan load validation, and FTG safety - #39
Draft
cursor[bot] wants to merge 3 commits into
Draft
Add regression tests for HD-map chopping, plan load validation, and FTG safety#39cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
…TG safety. Cover untested OpenDRIVE lane-sign path chops, GlobalPlan is_loadable/from_file velocity ramping, Follow-the-Gap z-band/bubble/interior-gap guards, and GoalArrivalMonitor missing-planner/goal edges. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
…ompare. Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
Co-authored-by: Majid Khonji <majid-khonji@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
chop_path/chop_path_from_two_sidesreverse positive-id lanes and slice start/goal indexes. A regression here emits a reversed or truncated HD-map global path._inset_dandsmoothen_path_savgolkeep corridor bounds and velocity samples aligned.is_loadablerejects missing keys, empty arrays, nested bounds, and non-JSON.from_filereplacesvelocity[0] <= 0withc20_min_ramp_start_velocityso a stored 0-speed first waypoint does not pin the ego at a standstill.goal_point, andreset()re-arming the rising edge so a falseGOAL_ARRIVEDcannot stop the run.Test files added/updated
test/c20_planning/test_c24_global_hdmap_planners.py(added)test/c20_planning/test_c21_planning_model.py(added)test/c30_control/test_c35_pure_pursuit.py(updated)test/c40_execution/test_c47_execution_tasks.py(added)Why these tests materially reduce regression risk
These are shared, high-blast-radius surfaces that landed on
devwithout dedicated tests: HD-map route geometry, stored global-plan ingest, LiDAR steering safety, and goal-stop event gating. They were not claimed by open coverage/bugfix drafts #17/#20/#22–#38.Validation
41 passed. Deterministic unit tests; no
slow/requires_datamarkers.