test(queries): pin escape_doublequote actually escapes quotes - #123
Open
TimeToBuildBob wants to merge 1 commit into
Open
TimeToBuildBob wants to merge 1 commit into
TimeToBuildBob wants to merge 1 commit into
Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
Regression test for the JS-style regex bug fixed in ActivityWatch#109, which shipped without a test. Git-Session-Id: 3d60
TimeToBuildBob
force-pushed
the
test/escape-doublequote-regression
branch
from
September 26, 2026 23:56
319711e to
88956d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#109 fixed
escape_doublequote, which used a JavaScript-style regex (re.sub('/"/g', ...)) and never matched anything. That fix landed without a test.This adds
tests/test_queries.py. It fails against the old implementation and passes on master.Context: ActivityWatch/aw-server-rust#734