Skip to content

test(queries): pin escape_doublequote actually escapes quotes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimeToBuildBob wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(queries): pin escape_doublequote actually escapes quotes #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,3 +401,15 @@ def test_browser_bucket_not_matched_by_hostname():
assert dict(browsersWithBuckets(buckets[2:])) == {
"firefox": "aw-watcher-web-firefox-synced-from-chrome-box"
}


from aw_client.queries import escape_doublequote


def test_escape_doublequote():
Comment thread
TimeToBuildBob marked this conversation as resolved.
# Regression: this once used a JS-style regex ('/"/g') and never matched.
assert (
escape_doublequote('aw-watcher-window_"host"') == 'aw-watcher-window_\\"host\\"'
)
assert escape_doublequote("no quotes") == "no quotes"
assert escape_doublequote("") == ""
Loading