fix(search,buckets): drop early-dev notice, case-insensitive search, relocate data-collection alert - #986
Conversation
…relocate data-collection alert
Search view:
- Remove the "This feature is still in early development" alert —
the tool has been stable enough to ship without the caveat.
- Search patterns are matched via the categorize() regex rule, which
is case-sensitive by default. Set ignore_case: true (already
supported by the Rule type and used elsewhere, e.g. classes.ts) so
a search for "vlc" also matches "VLC".
Buckets ("Raw Data") view:
- Move the "Are you looking to collect more data?" alert from the
top of the page to the bottom, after the import/export section.
- The hr separating that section from the aw-devonly tools block was
left dangling in production builds (aw-devonly renders nothing
when PRODUCTION is true), so it appeared as a stray divider with
nothing below it. Reuse it to separate the main content from the
relocated alert instead.
Fixes ActivityWatch#985
Git-Session-Id: c5e12cfc-abed-5ea8-a6e3-eb5ea6669462
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
=======================================
Coverage 55.13% 55.13%
=======================================
Files 49 49
Lines 3011 3011
Branches 686 686
=======================================
Hits 1660 1660
Misses 1334 1334
Partials 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI-green and mergeable — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
🤖 AI code reviewThis PR removes the early-development alert from the Search view, makes the search regex case-insensitive by adding Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No thread-worthy findings. Advisory notes follow; they are retained without opening review threads. 1 advisory finding (summary-only, not scored)These P2 guard, heuristic, trade-off, or documentation claims are retained for judgment without opening review threads.
This is a How this was verified: static preflight: fix-commit + touched-files scan (rule 7) Files changed (2) — the diff as I read it
Reviewed Maintainer commands
|
Summary
Addresses #985 (@ErikBjare):
vlcdidn't matchVLCbecause thecategorize()regex rule defaults tocase-sensitive. Set
ignore_case: true, the same flag already used for categoryrules elsewhere (
classes.ts).alert from the top of the page to the bottom, after the import/export section.
hrthat used to separate the import/export section fromthe
aw-devonlytools block was effectively dangling in production —aw-devonlyrenders nothing when
PRODUCTIONis true, so that divider had nothing below itand looked like a stray/misplaced line. Reused it to separate the main content
from the relocated alert instead, so it's no longer orphaned.
Test plan
npx eslint --ext=js,ts,vueon the changed files — cleannpx vue-cli-service lint --no-fixon the changed files — no lint errorsnode scripts/check-locales.mjs— same pre-existing failures as master(
nav.aiSummarymissing in uk/de/ru/zh-CN), nothing new introducedwith search data in this environment)