Skip to content

fix(search,buckets): drop early-dev notice, case-insensitive search, relocate data-collection alert - #986

Merged
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/search-tool-cleanup-985
Sep 18, 2026
Merged

ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/search-tool-cleanup-985

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Summary

Addresses #985 (@ErikBjare):

  • Search view: remove the "This feature is still in early development" alert.
  • Search view: make the search pattern match case-insensitively — a search for
    vlc didn't match VLC because the categorize() regex rule defaults to
    case-sensitive. Set ignore_case: true, the same flag already used for category
    rules elsewhere (classes.ts).
  • Buckets ("Raw Data") view: move the "Are you looking to collect more data?"
    alert from the top of the page to the bottom, after the import/export section.
  • Buckets view: the hr that used to separate the import/export section from
    the aw-devonly tools block was effectively dangling in production — aw-devonly
    renders nothing when PRODUCTION is true, so that divider had nothing below it
    and looked like a stray/misplaced line. Reused it to separate the main content
    from the relocated alert instead, so it's no longer orphaned.

Test plan

  • npx eslint --ext=js,ts,vue on the changed files — clean
  • npx vue-cli-service lint --no-fix on the changed files — no lint errors
  • node scripts/check-locales.mjs — same pre-existing failures as master
    (nav.aiSummary missing in uk/de/ru/zh-CN), nothing new introduced
  • Manual visual check in a running dev build (not done — no local backend
    with search data in this environment)

…relocate data-collection alert

Search view:
- Remove the "This feature is still in early development" alert —
  the tool has been stable enough to ship without the caveat.
- Search patterns are matched via the categorize() regex rule, which
  is case-sensitive by default. Set ignore_case: true (already
  supported by the Rule type and used elsewhere, e.g. classes.ts) so
  a search for "vlc" also matches "VLC".

Buckets ("Raw Data") view:
- Move the "Are you looking to collect more data?" alert from the
  top of the page to the bottom, after the import/export section.
- The hr separating that section from the aw-devonly tools block was
  left dangling in production builds (aw-devonly renders nothing
  when PRODUCTION is true), so it appeared as a stray divider with
  nothing below it. Reuse it to separate the main content from the
  relocated alert instead.

Fixes ActivityWatch#985

Git-Session-Id: c5e12cfc-abed-5ea8-a6e3-eb5ea6669462
@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with both functional and layout changes behaving consistently with existing application conventions.

Summary

This PR updates the Search and Raw Data views:

  • Removes the early-development warning from Search.
  • Makes Search categorization case-insensitive using the backend’s established ignore_case rule option.
  • Moves the data-collection alert below the import/export section.
  • Reuses the divider so it no longer appears orphaned in production.

Reviews (1) · Last reviewed commit: "fix(search,buckets): drop early-dev noti..."

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.13%. Comparing base (52ad886) to head (15b302c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   55.13%   55.13%           
=======================================
  Files          49       49           
  Lines        3011     3011           
  Branches      686      686           
=======================================
  Hits         1660     1660           
  Misses       1334     1334           
  Partials       17       17           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@TimeToBuildBob

TimeToBuildBob commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

This PR removes the early-development alert from the Search view, makes the search regex case-insensitive by adding ignore_case: true to the regex rule, and relocates the 'more watchers' alert in the Buckets view from the top to the bottom, reusing the existing hr divider.

Safe to merge — no P0/P1 findings

Confidence 5/5

No thread-worthy findings. Advisory notes follow; they are retained without opening review threads.

1 advisory finding (summary-only, not scored)

These P2 guard, heuristic, trade-off, or documentation claims are retained for judgment without opening review threads.

⚠️ P2 mediumsrc/views/Buckets.vue

This is a fix(...) PR but no test files are included in the diff. Erik's feedback: 'where is the repro & fixes they are supposed to catch' (gptme#3441), 'that measurement should come with a regression test' (gptme#3446). Add a test that would have caught this bug. (Advisory: Erik merged all such PRs but consistently requested tests.)

Add a test file that reproduces the bug before the fix and passes after it.

How this was verified: static preflight: fix-commit + touched-files scan (rule 7)

Files changed (2) — the diff as I read it
  • src/views/Buckets.vue — Moves the b-alert for 'more watchers' from the top of the template to after the import/export section, reusing the existing hr.
  • src/views/Search.vue — Removes the early-development warning alert and adds ignore_case: true to the regex rule in the search query.

Reviewed 15b302cb46bd · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 14s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

@ErikBjare
ErikBjare merged commit 262322d into ActivityWatch:master Sep 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants