fix: use correct column names when plotting the lickspout positions in qc#44
Open
arjunsridhar12345 wants to merge 5 commits into
Open
Conversation
arjunsridhar12345
marked this pull request as ready for review
July 17, 2026 23:51
|
Can you make all the plots be aligned in time? The xlimit starts at different points for the different plots |
Collaborator
Author
|
tried to align in this commit: 5ad3b1e Sample output is below: 
|
|
Whats the blocker on getting #22 fixed? |
Collaborator
Author
|
@micahwoodard I think were you going to talk to Jessy about the lickspout positions? |
|
@arjunsridhar12345 replied on the issue :) |
@arjunsridhar12345 what are you looking at for stage positions? These graphs imply to me that the bias correction isn't working as intended and wanted to try and debugg |
|
@arjunsridhar12345 You can test to make sure the QC plot shows mid-session lickspout movements on this session: 864253_2026-07-17_19-28-27 |
alexpiet
requested changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to close #43. Note that this gets the lickspout positions to show up in the QC plot. It's currently using the positions from the static manipulator software event which is not correct. This does NOT fix issue #22 which still needs to be looked at for getting the correct values.
Sample output, now showing lickspout position in the plot. Not sure if we want to merge this or wait for #22 to be fixed first: