autotest: run BatteryFailsafe at default speedup#33765
Merged
peterbarker merged 1 commit intoJul 20, 2026
Merged
Conversation
BatteryFailsafe pins SIM_SPEEDUP to 4 for its entire duration, making it the fourth most expensive test in all of CI at ~320 wall-seconds per run. The override has been carried through several refactors with no recorded rationale; the original 2013 test did not set it. Battery failsafe timing is entirely simulation-time: the voltage comes from SIM_BATT_VOLTAGE and BATT_LOW_TIMER counts simulation seconds, so there is no wall-clock coupling that would require a reduced speedup (unlike the GCS failsafe tests, where the test framework's wall-paced heartbeats justify one). Remove the override so the test runs at the suite default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
khancyr
approved these changes
Jul 20, 2026
khancyr
left a comment
Contributor
There was a problem hiding this comment.
if that has been tested, go for it, the analysis is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove pointless speed limiting in battery failsafe testing
Classification & Testing (check all that apply and add your own)
This has been soak-tested in my own fork.
Description
BatteryFailsafe pins SIM_SPEEDUP to 4 for its entire duration, making it the fourth most expensive test in all of CI at ~320 wall-seconds per run. The override has been carried through several refactors with no recorded rationale; the original 2013 test did not set it.
Battery failsafe timing is entirely simulation-time: the voltage comes from SIM_BATT_VOLTAGE and BATT_LOW_TIMER counts simulation seconds, so there is no wall-clock coupling that would require a reduced speedup (unlike the GCS failsafe tests, where the test framework's wall-paced heartbeats justify one). Remove the override so the test runs at the suite default.