Switch to stronger model in CI builds - #776
Merged
Merged
Conversation
Contributor
Author
|
Two empty responses in the CI failures, not sure what that's about. Maybe context limits? |
eb8680
marked this pull request as draft
September 2, 2026 23:55
Contributor
Author
|
It seems the problem is |
eb8680
changed the title
gpt-5-mini is a reasoning model, and reasoning tokens are charged against max_tokens. Two tests size that budget for a non-reasoning model and broke: test_agent_tool_names_are_valid_integration asks for 64 tokens, all 64 of which went to reasoning, leaving empty content that hooks.py decodes as "no final response"; and the [tuple-empty] serialization case exhausted its three-attempt retry for the same reason. Accommodating that would have meant either pinning reasoning_effort in the tests or inflating budgets against a spend that isn't bounded by anything we control. gpt-4.1-mini is non-reasoning, so those budgets mean what they say and both tests pass untouched. It also carries a 1M context against gpt-5-mini's 272K and gpt-4o-mini's 128K, which is the window that overflowed in #773, and it is markedly faster on the job that gates pull requests: the basics examples run in 33s against 3m7s, with flight_booking alone converging in 24s where gpt-4o-mini ground through retries for ~4 minutes before failing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
eb8680
marked this pull request as ready for review
September 3, 2026 01:19
datvo06
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #773 (hopefully)