fix: use pnpm catalog for shared BTMT deps, fixing playground genre-tree-view drift - #25
Merged
Merged
Conversation
…ree-view drift apps/playground pinned genre-tree-view at 0.4.0 independently of packages/app-kit's 0.5.0, so the playground rendered 0.5.0's wheel/tree markup styled with 0.4.0's CSS, causing an overlapping, unclipped wheel.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenreTreeWheel/GenreTreerendering reported inapps/playground:apps/playground/package.jsonpinned@behindthemusictree/genre-tree-viewat0.4.0independently ofpackages/app-kit's own0.5.0dependency. The playground rendered0.5.0's new absolutely-positioned pan/zoom markup styled with0.4.0's CSS (no clipping/positioning rules for it), producing the overlap.catalog:entry inpnpm-workspace.yamlfor@behindthemusictree/genre-tree-view,@behindthemusictree/ui, and@behindthemusictree/brand; bothpackages/app-kitandapps/playgroundnow reference"catalog:"instead of hardcoding each version separately — single source of truth, so this class of drift can't recur.Test plan
pnpm install— singlegenre-tree-view@0.5.0resolved everywhere (0.4.0 dropped)pnpm build— both packages build cleanpnpm lint— cleanpnpm --filter @behindthemusictree/app-kit test— 25/25 passing