Skip to content

fix: use pnpm catalog for shared BTMT deps, fixing playground genre-tree-view drift #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andreas-Garcia merged 1 commit into from
Aug 14, 2026
Merged

fix: use pnpm catalog for shared BTMT deps, fixing playground genre-tree-view drift #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ Format based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [Unreleased]

### Fixed

- `apps/playground` was pinned to `@behindthemusictree/genre-tree-view@0.4.0` directly, independent
of `packages/app-kit`'s own `0.5.0` dependency, so the playground rendered `0.5.0`'s
`GenreTreeWheel`/`GenreTree` markup (new absolutely-positioned pan/zoom stage) styled with
`0.4.0`'s CSS (no clipping/positioning rules for it), producing an overlapping, unclipped wheel
and tree. Fixed by introducing a pnpm `catalog:` entry in `pnpm-workspace.yaml` for
`@behindthemusictree/genre-tree-view`, `@behindthemusictree/ui`, and `@behindthemusictree/brand`,
and switching both `packages/app-kit` and `apps/playground` to reference `"catalog:"` instead of
hardcoding each version separately — a single source of truth per dependency, so this class of
drift can't recur.

## [1.0.1] - 2026-08-14

### Changed
Expand Down
4 changes: 2 additions & 2 deletions apps/playground/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
},
"dependencies": {
"@behindthemusictree/app-kit": "workspace:*",
"@behindthemusictree/genre-tree-view": "0.4.0",
"@behindthemusictree/ui": "^0.1.0",
"@behindthemusictree/genre-tree-view": "catalog:",
"@behindthemusictree/ui": "catalog:",
"@tanstack/react-query": "^5.72.2",
"react": "^18.2.0",
"react-dom": "^18.2.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/app-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@
"react-dom": ">=18.0.0"
},
"dependencies": {
"@behindthemusictree/brand": "12.0.0",
"@behindthemusictree/genre-tree-view": "0.5.0",
"@behindthemusictree/ui": "^0.1.0",
"@behindthemusictree/brand": "catalog:",
"@behindthemusictree/genre-tree-view": "catalog:",
"@behindthemusictree/ui": "catalog:",
"clsx": "^2.1.1",
"lucide-react": "^0.487.0",
"react-icons": "^5.5.0",
Expand Down
37 changes: 18 additions & 19 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ packages:
- "packages/*"
- "apps/*"

catalog:
"@behindthemusictree/brand": 12.0.0
"@behindthemusictree/genre-tree-view": 0.5.0
"@behindthemusictree/ui": ^0.1.0

allowBuilds:
esbuild: true
sharp: false
Expand Down
Loading