Skip to content

feat(naval): oceanic fleet blockade, harpoon cannons, and cargo interception engine - #212

Open
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-naval-blockade-1787900479429
Open

feat(naval): oceanic fleet blockade, harpoon cannons, and cargo interception engine#212
angelTomo9 wants to merge 2 commits into
Bitcoindefi:mainfrom
angelTomo9:feat-naval-blockade-1787900479429

Conversation

@angelTomo9

Copy link
Copy Markdown

Summary

Implements an oceanic fleet blockade, sea chokepoints, harpoon grappling hooks, broadside cannon salvos, and toll tax enforcement engine for OpenAO MMORPG.

Features

  • Warship catalog (War Galleon, Armored Frigate, Dreadnought Ironclad)
  • Sea chokepoint territory control radius calculations
  • Harpoon grappling hook mechanics immobilizing target vessels
  • Broadside cannon salvos with armor mitigation and wreckage gold salvage
  • Full unit test coverage under Vitest

Comment thread api/src/lib/navalFleetBlockade.ts
@gitar-bot

gitar-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Implements oceanic fleet blockade mechanics with warship catalog, sea chokepoints, harpoon grappling, broadside cannons, and toll enforcement for the MMORPG. Harpoon range gating was fixed to use specific harpoonRangeTiles instead of control radius. No issues found.

✅ 1 resolved
Bug: Harpoon range ignored; uses control radius instead

📄 api/src/lib/navalFleetBlockade.ts:16 📄 api/src/lib/navalFleetBlockade.ts:43-45 📄 api/src/lib/navalFleetBlockade.ts:110-124
fireHarpoonGrapple determines whether a target is reachable via isVesselInBlockadeZone, which compares distance against blockade.controlRadiusTiles. The per-warship harpoonRangeTiles value (25/35/45) defined in WARSHIP_CATALOG and WarshipData is never read anywhere, so the advertised harpoon-range mechanic is non-functional — all warships grapple at the control radius regardless of class. Compute the harpoon distance separately and gate the grapple on WARSHIP_CATALOG[blockade.warshipClass].harpoonRangeTiles.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant