Skip to content

fix: disable allocator exclusion by default - #489

Merged
art049 merged 1 commit into
mainfrom
cod-3301-fix-disable-allocator-exclusion-being-on-by-default
Jul 29, 2026
Merged

fix: disable allocator exclusion by default#489
art049 merged 1 commit into
mainfrom
cod-3301-fix-disable-allocator-exclusion-being-on-by-default

Conversation

@not-matthias

Copy link
Copy Markdown
Member

No description provided.

Comment thread src/cli/shared.rs
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

This PR disables allocator exclusion by default.

  • Changes the shared run/exec exclude_allocations CLI default from true to false.
  • Leaves explicit CLI and environment-variable overrides available.

Confidence Score: 4/5

The PR appears safe to merge, but its deprecated-option warning should be updated to describe the new allocator-exclusion default accurately.

The changed default flows consistently through run and exec, with the only accepted issue being stale user-facing guidance that still claims allocator exclusion defaults to true.

Files Needing Attention: src/cli/shared.rs and src/cli/experimental.rs

Important Files Changed

Filename Overview
src/cli/shared.rs Changes the allocator-exclusion default for both run and exec; the related deprecated-option warning still documents the previous default.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
### Issue 1
src/cli/shared.rs:129
**Stale allocator default guidance**

The deprecated `--experimental-exclude-allocations` warning still says allocator exclusion defaults to true, while this change makes the effective default false, giving users incorrect guidance when configuring benchmark measurements.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix: disable allocator exclusion by defa..." | Re-trigger Greptile

@art049
art049 merged commit e5a7a3c into main Jul 29, 2026
21 checks passed
@art049
art049 deleted the cod-3301-fix-disable-allocator-exclusion-being-on-by-default branch July 29, 2026 10:23
@codspeed-hq

codspeed-hq Bot commented Jul 29, 2026

Copy link
Copy Markdown

Performance comparison unavailable

The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable.

What changed between base and head:

Re-run the base with the same settings to get a valid performance comparison.


Comparing cod-3301-fix-disable-allocator-exclusion-being-on-by-default (003bfb4) with main (0418479)

Open in CodSpeed

not-matthias added a commit that referenced this pull request Jul 29, 2026
Allocation exclusion has defaulted to false since #489, but the
deprecation warning still told users it defaults to true, and the
serde-skip rationale still called --exclude-allocations=false the
"opt-out path".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants