fix: disable allocator exclusion by default - #489
Conversation
Greptile SummaryThis PR disables allocator exclusion by default.
Confidence Score: 4/5The PR appears safe to merge, but its deprecated-option warning should be updated to describe the new allocator-exclusion default accurately. The changed default flows consistently through run and exec, with the only accepted issue being stale user-facing guidance that still claims allocator exclusion defaults to true. Files Needing Attention: src/cli/shared.rs and src/cli/experimental.rs
|
| Filename | Overview |
|---|---|
| src/cli/shared.rs | Changes the allocator-exclusion default for both run and exec; the related deprecated-option warning still documents the previous default. |
Prompt To Fix All With AI
### Issue 1
src/cli/shared.rs:129
**Stale allocator default guidance**
The deprecated `--experimental-exclude-allocations` warning still says allocator exclusion defaults to true, while this change makes the effective default false, giving users incorrect guidance when configuring benchmark measurements.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix: disable allocator exclusion by defa..." | Re-trigger Greptile
Performance comparison unavailableThe base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable. What changed between base and head:
Re-run the base with the same settings to get a valid performance comparison. Comparing |
Allocation exclusion has defaulted to false since #489, but the deprecation warning still told users it defaults to true, and the serde-skip rationale still called --exclude-allocations=false the "opt-out path".
No description provided.