wizard: disable formal/informal for English surveys; fix toggle transition (#43) - #44
Merged
Merged
Conversation
…ition (#43) Two unrelated UI papercuts that came up while testing #39. * **English hides the Sie/Du toggle.** The form-of-address choice is a German-only concept, so when surveyLanguage is English the buttons are disabled with a small hint, and the generator receives 'you' instead of 'du'/'Sie' (English has no formal/informal split). The persisted value is left alone, so switching back to German restores the user's previous choice. * **Toggle-button transition.** The selected state changed both background and font-weight under `transition: all 0.2s`. Colour fades smoothly but font-weight can't be interpolated, so it snapped at the start — the two felt out of sync. Now only background-color and border-color transition; font-weight snaps as it always did. formOfAddress() gains a surveyLanguage parameter (defaults to 'de' for backwards compat) and the SIGNATURE description mentions the new value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated UI papercuts that came up while testing #39.
English hides the Sie/Du toggle. The form-of-address choice is a German-only concept, so when
surveyLanguageis English the buttons are disabled with a small hint, and the generator receives"you"instead of"du"/"Sie"(English has no formal/informal split). The persisted value is left alone, so switching back to German restores the user's previous choice.Toggle-button transition. The selected state changed both background and font-weight under
transition: all 0.2s. Colour fades smoothly but font-weight can't be interpolated, so it snapped at the start — the two felt out of sync. Now onlybackground-colorandborder-colortransition; font-weight snaps as it always did.formOfAddress()gains asurveyLanguageparameter (defaults to'de'for backwards compat) and the SIGNATURE description mentions the new value.Verified:
npm run test:unit(82 pass),npm run test:e2e(45 pass),npm run check,npm run lint.Closes #43.