Skip to content

Changed a couple of AVXThresholdProcessor configuration declarations …#327

Merged
bieryAtFnal merged 3 commits into
developfrom
kbiery/test_config_fixes
Jul 6, 2026
Merged

Changed a couple of AVXThresholdProcessor configuration declarations …#327
bieryAtFnal merged 3 commits into
developfrom
kbiery/test_config_fixes

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Contributor

…to try to get the data type and syntax correct.

Description

Marco noticed that some of our configuration settings for AVXThresholdProcessor were not correct. This PR includes the fixes in this repo.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)

@bieryAtFnal bieryAtFnal requested review from eflumerf and mroda88 July 6, 2026 13:40

@mroda88 mroda88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, can I ask you to fix also ru-segment.data.xml? I can do it if you prefer. If you check the file, you'll get these errors:

2026-Jul-06 13:43:57,728 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:137] Error sourcecode/daqsystemtest/config/daqsystemtest/ru-segment.data.xml misses include of schema/appmodel/hermes.schema.xml required by wib_101_link0 of class HermesDataSender
2026-Jul-06 13:43:57,803 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:137] Error sourcecode/daqsystemtest/config/daqsystemtest/ru-segment.data.xml misses include of schema/appmodel/hermes.schema.xml required by wib_201_link0 of class HermesDataSender
2026-Jul-06 13:43:57,803 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error sourcecode/daqsystemtest/config/daqsystemtest/ru-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction
2026-Jul-06 13:43:57,803 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error sourcecode/daqsystemtest/config/daqsystemtest/ru-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction

@eflumerf

eflumerf commented Jul 6, 2026

Copy link
Copy Markdown
Member

A couple more:

[Mon Jul 06 09:27:09] ~/Desktop/dune-daq-base/dev-dfmodules495-260706/sourcecode/daqsystemtest/config/daqsystemtest (kbiery/test_config_fixes)
[eflumerf@ironvirt9]$ for file in *.data.xml;do echo;echo $file;echo;oks_check_schema -f $file|grep Error;done

ccm.data.xml


connections.data.xml


df-segment.data.xml

2026-Jul-06 09:27:19,756 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error df-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction

example-configs.data.xml


example-hsi-configs.data.xml


fsm.data.xml


hosts.data.xml


hsi-dts-segment.data.xml

2026-Jul-06 09:27:20,033 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error hsi-dts-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction

hsi-fake-segment.data.xml

2026-Jul-06 09:27:20,181 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error hsi-fake-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction

integrationtest-objects.data.xml


moduleconfs.data.xml


ru-segment.data.xml

2026-Jul-06 09:27:20,349 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error ru-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction
2026-Jul-06 09:27:20,364 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:122] Error ru-segment.data.xml misses include of config/daqsystemtest/fsm.data.xml required by FSMconfiguration_noAction
2026-Jul-06 09:27:20,364 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:137] Error ru-segment.data.xml misses include of schema/appmodel/hermes.schema.xml required by wib_101_link0 of class HermesDataSender
2026-Jul-06 09:27:20,364 LOG [main(...) at /tmp/root/spack-stage/spack-stage-oks-NB_DEV_260706_A9-m5o6vsrlgem4qtrwhhpldhacnuy4i6dz/spack-src/apps/oks_check_schema.cxx:137] Error ru-segment.data.xml misses include of schema/appmodel/hermes.schema.xml required by wib_201_link0 of class HermesDataSender

trigger-segment.data.xml

@bieryAtFnal

Copy link
Copy Markdown
Contributor Author

Thanks guys.
I believe that I've fixed the additional problems that you mentioned...

@mroda88 mroda88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against today's nightly and I don't see any more issues.

@bieryAtFnal bieryAtFnal merged commit 64b92fa into develop Jul 6, 2026
5 checks passed
@bieryAtFnal bieryAtFnal deleted the kbiery/test_config_fixes branch July 6, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants