fix(dotnet): declare FFE capability from 3.54 - #7612
Open
pavlokhrebto wants to merge 6 commits into
Open
pavlokhrebto wants to merge 6 commits into
pavlokhrebto wants to merge 6 commits into
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: cde1fb0 | Docs | View more details | Give us feedback! |
…ebto/dotnet-3.53-ffe-capability
5 tasks
…ebto/dotnet-3.53-ffe-capability
pavlokhrebto
marked this pull request as ready for review
September 14, 2026 12:37
pavlokhrebto
requested review from
NachoEchevarria,
aarsilv and
leoromanovsky
and removed request for
a team
September 14, 2026 12:37
leoromanovsky
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dd-trace-dotnet3.54.0 recognizesDD_FEATURE_FLAGS_CONFIGURATION_SOURCE=remote_configand reportsFFE_FLAG_CONFIGURATION_RULESduring the Remote Config capability completeness test. The capability registry does not declare that bit for dotnet, so validation rejects the correctly reported capability asseen_but_not_expectedand fails the dotnet parametric job.Changes
Updates the version-aware dotnet capability registry so
FFE_FLAG_CONFIGURATION_RULESis expected starting with dotnet 3.54.0. Earlier dotnet versions keep their existing expected capability set.Also removes the temporary
missing_featuredeclaration fortest_default_capability_completenessfrommanifests/dotnet.yml, added in #7673. It bridged the window where this registry expected capability 46 but no published dotnet snapshot reported it. That window is closed, and leaving the waiver would disable the completeness check for dotnet permanently.Decisions
The capability is declared at
>=3.54.0instead of in the dotnet base set. Earlier versions contain the registration code, but Feature Flags only started when the legacyDD_EXPERIMENTAL_FLAGGING_PROVIDER_ENABLEDopt-in was set, whichDEFAULT_ENVVARSdoes not set, so the capability was never observable. 3.53.0 enables Feature Flags by default, but the capability is only advertised from 3.54.0, when the tracer subscribes toFFE_FLAGSfor theremote_configsource. dotnet advertises it only for that source, matching Node, which gates onDD_FEATURE_FLAGS_CONFIGURATION_SOURCE === 'remote_config'inproxy.js.Verification
./format.sh— no changes./run.sh TEST_THE_TEST tests/test_the_test/test_capabilities.py— passed2fc97594, and thelatest_snapshotimage was rebuilt from that commit at 10:59 UTC, so the snapshot the dev jobs run now advertises the capability. Both halves of this PR therefore have to land together: the registry entry alone fails the released 3.53.0 job, and the waiver alone hides the check.[dotnet@pavlo.khrebto/EX-2703/ffe-module-wiring]in the title,System Tests (dotnet, dev) / parametricpassed on run 34122374529 against a branch image of #9044.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present