Skip to content

chore(dotnet): temporarily skip capability completeness during FFE rollout - #7673

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
pavlo.khrebto/skip-dotnet-capability-completeness
Sep 8, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
pavlo.khrebto/skip-dotnet-capability-completeness

Conversation

@pavlokhrebto

@pavlokhrebto pavlokhrebto commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Motivation

dd-trace-dotnet starts advertising FFE_FLAG_CONFIGURATION_RULES (capability 46) in 3.54.0, from DataDog/dd-trace-dotnet#9044.

test_default_capability_completeness enforces strict equality for non-prerelease versions, and dotnet snapshot builds report a clean version, so:

  • the tracer PR fails with seen_but_not_expected_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>};
  • adding the registry entry first is not an option either, because it then fails with expected_but_not_seen_capabilities until the tracer ships.

Changes

Declares test_default_capability_completeness as missing_feature for dotnet, so the tracer PR can merge with a green system_tests check. #7612 removes this declaration in the same PR that declares the capability at >=3.54.0, restoring strict checking.

Merge order:

  1. this PR;
  2. DataDog/dd-trace-dotnet#9044;
  3. #7612 — declares >=3.54.0 and removes the declaration added here.

Decisions

Skipping one test for one language is preferred to merging the tracer PR with a red system_tests check.

The pair is already verified: with [dotnet@pavlo.khrebto/EX-2703/ffe-module-wiring] in the title, System Tests (dotnet, dev) / parametric passed on run 34122374529, which ran the suite against a branch image of the tracer PR.

Verification

  • ./format.sh — no changes
  • ./run.sh TEST_THE_TEST tests/test_the_test/test_capabilities.py — passed

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers

@pavlokhrebto pavlokhrebto changed the title chore(dotnet): temporarily skip capability completeness for FFE rollout chore(dotnet): temporarily skip capability completeness during FFE rollout Sep 8, 2026
@pavlokhrebto
pavlokhrebto marked this pull request as ready for review September 8, 2026 13:04
@pavlokhrebto
pavlokhrebto requested a review from a team as a code owner September 8, 2026 13:04
@pavlokhrebto
pavlokhrebto requested review from VianneyRuhlmann, andrewlock and leoromanovsky and removed request for a team September 8, 2026 13:04
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 9d2de45 into main Sep 8, 2026
34 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the pavlo.khrebto/skip-dotnet-capability-completeness branch September 8, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants