chore(dotnet): temporarily skip capability completeness during FFE rollout - #7673
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoSep 8, 2026
Conversation
Contributor
|
|
pavlokhrebto
marked this pull request as ready for review
September 8, 2026 13:04
pavlokhrebto
requested review from
VianneyRuhlmann,
andrewlock and
leoromanovsky
and removed request for
a team
September 8, 2026 13:04
andrewlock
approved these changes
Sep 8, 2026
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
pavlo.khrebto/skip-dotnet-capability-completeness
branch
September 8, 2026 13:27
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dd-trace-dotnetstarts advertisingFFE_FLAG_CONFIGURATION_RULES(capability 46) in 3.54.0, from DataDog/dd-trace-dotnet#9044.test_default_capability_completenessenforces strict equality for non-prerelease versions, and dotnet snapshot builds report a clean version, so:seen_but_not_expected_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>};expected_but_not_seen_capabilitiesuntil the tracer ships.Changes
Declares
test_default_capability_completenessasmissing_featurefor dotnet, so the tracer PR can merge with a greensystem_testscheck. #7612 removes this declaration in the same PR that declares the capability at>=3.54.0, restoring strict checking.Merge order:
>=3.54.0and removes the declaration added here.Decisions
Skipping one test for one language is preferred to merging the tracer PR with a red
system_testscheck.The pair is already verified: with
[dotnet@pavlo.khrebto/EX-2703/ffe-module-wiring]in the title,System Tests (dotnet, dev) / parametricpassed on run 34122374529, which ran the suite against a branch image of the tracer PR.Verification
./format.sh— no changes./run.sh TEST_THE_TEST tests/test_the_test/test_capabilities.py— passedWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present