Migrate CI secrets to Vault

[nccatoni]

Motivation

The system-tests GitLab pipeline still reads Docker Hub credentials from the deprecated AWS SSM mechanism. APMSP-3978 requires migrating these credentials to the repository-scoped Vault namespace enabled by DataDog/vault-config#10327.

Changes

The GitLab jobs that authenticate to Docker Hub now read the username and password fields from kv/k8s/gitlab-runner/system-tests/docker-login with the Vault CLI. Existing environment variable names and Docker/crane authentication behavior remain unchanged.

Testing

• Parsed .gitlab-ci.yml successfully with PyYAML.
• Passed yamllint and git diff --check.
• Confirmed no legacy ci.system-tests.docker-login* SSM lookups remain and all four consumers use the Vault path.
• Full formatter and pytest execution could not complete in the sandbox because yamlfmt installation was blocked by network access and the Docker daemon is unavailable; mypy and ruff completed successfully before the formatter reached that installation step.

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

---

PR by Bits - View session in Datadog

Comment @DataDog to request changes

[datadog-datadog-prod-us1]

View session in Datadog

Bits Code status: ✅ Done

CI Auto-fix: Disabled | Enable

Comment @DataDog to request changes

[datadog-datadog-prod-us1]

I can only run on private repositories.

[github-actions]

CODEOWNERS have been resolved as:

.gitlab-ci.yml                                                          @DataDog/system-tests-core

[datadog-datadog-prod-us1]

 

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

DataDog/system-tests | build_base_images

View more details · View in GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9723c31 | Docs | View more details | Give us feedback!}