Skip to content

Migrate CI secrets to Vault #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nccatoni wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −8
Draft

Migrate CI secrets to Vault #7717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ check_merge_labels:
- dd-octo-sts version
- dd-octo-sts debug --scope DataDog/system-tests --policy self.gitlab-read
- dd-octo-sts token --scope DataDog/system-tests --policy self.gitlab-read > token.txt
- export DOCKER_LOGIN=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN_PASS=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-pass-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN=$(vault kv get -field=username kv/k8s/gitlab-runner/system-tests/docker-login)
- export DOCKER_LOGIN_PASS=$(vault kv get -field=password kv/k8s/gitlab-runner/system-tests/docker-login)
script:
- docker buildx version
- export GITHUB_TOKEN=$(cat token.txt)
Expand All @@ -287,8 +287,8 @@ generate_system_tests_lambda_proxy_image:
stage: system-tests-utils
allow_failure: false
before_script:
- export DOCKER_LOGIN=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN_PASS=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-pass-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN=$(vault kv get -field=username kv/k8s/gitlab-runner/system-tests/docker-login)
- export DOCKER_LOGIN_PASS=$(vault kv get -field=password kv/k8s/gitlab-runner/system-tests/docker-login)
- echo "$DOCKER_LOGIN_PASS" | docker login --username "$DOCKER_LOGIN" --password-stdin
script:
- SYSTEM_TEST_BUILD_ATTEMPTS=3 SYSTEM_TEST_BUILD_TIMEOUT=240 ./build.sh -i lambda-proxy
Expand Down Expand Up @@ -420,8 +420,8 @@ mirror_images:
- curl -sSL "https://github.com/google/go-containerregistry/releases/download/${CRANE_VERSION}/go-containerregistry_Linux_x86_64.tar.gz" | tar -xz -C /usr/local/bin crane
# This is the only job that pulls from Docker Hub (the mirror sources), so it
# is the only one that needs Docker Hub auth (avoids unauthenticated rate limits).
- export DOCKER_LOGIN=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN_PASS=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-pass-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN=$(vault kv get -field=username kv/k8s/gitlab-runner/system-tests/docker-login)
- export DOCKER_LOGIN_PASS=$(vault kv get -field=password kv/k8s/gitlab-runner/system-tests/docker-login)
- echo "$DOCKER_LOGIN_PASS" | crane auth login index.docker.io --username "$DOCKER_LOGIN" --password-stdin
script:
# Shares its CI_IMAGE-vs-computed-tag check with the build_ci_image job.
Expand Down Expand Up @@ -470,8 +470,8 @@ build_base_images:
optional: true
stage: e2e
before_script:
- export DOCKER_LOGIN=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN_PASS=$(aws ssm get-parameter --region us-east-1 --name ci.system-tests.docker-login-pass-write --with-decryption --query "Parameter.Value" --out text)
- export DOCKER_LOGIN=$(vault kv get -field=username kv/k8s/gitlab-runner/system-tests/docker-login)
- export DOCKER_LOGIN_PASS=$(vault kv get -field=password kv/k8s/gitlab-runner/system-tests/docker-login)
- echo "$DOCKER_LOGIN_PASS" | docker login --username "$DOCKER_LOGIN" --password-stdin
- ln -sf /system-tests/venv venv
- source venv/bin/activate
Expand Down
Loading