Skip to content

fix(pchronicle): generate ids for compact JSONL records - #121

Closed
reiase wants to merge 11 commits into
mainfrom
fix/macos-pvisor-cases
Closed

fix(pchronicle): generate ids for compact JSONL records#121
reiase wants to merge 11 commits into
mainfrom
fix/macos-pvisor-cases

Conversation

@reiase

@reiase reiase commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • accept JSONL records without a usable id
  • generate stable IDs as source_filename#line_number
  • preserve original records byte-for-byte on export
  • keep missing or invalid timestamp values as hard errors

Validation

  • cargo fmt --all -- --check
  • cargo check -p persisting-pchronicle --locked
  • cargo check -p persisting-pchronicle-cli --locked

The compact JSONL unit test could not link because the macOS filesystem had no free space (ld: No space left on device).

@reiase
reiase force-pushed the fix/macos-pvisor-cases branch from d30921b to 8d49678 Compare September 6, 2026 15:46
@reiase

reiase commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #122, which retargets to main and includes this PR's commits plus chronicle.manifest / catalog mounts / S3 region apply.

@reiase

reiase commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #122 (includes this branch's changes).

@reiase reiase closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant