feat(pchronicle): compact JSONL, chronicle.manifest, catalog mounts - #122
Merged
Conversation
…on apply Large compact-jsonl datasets and MinIO/S3 aliases were failing or freezing because discovery/explorer expanded every record and OpenDAL opened s3:// before AWS_REGION was applied. Add RFC-0015 sidecars with read-side nested counts, mount all catalog datasets on serve, and apply alias/catalog S3 env before the Tokio runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
reiase
changed the title
Consolidated multiple lines of code into single lines for better clarity in `agent.rs`, `lib.rs`, `main.rs`, `settings.rs`, and `tests.rs`. Adjusted formatting in various sections to enhance readability without altering functionality. This change aims to streamline the codebase and maintain consistency across the project.
Clippy denies Command::Serve growing past the enum size threshold after catalog serve fields were added; keep the payload behind a Box. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id(stablesource_filename#line_number), accept JSON documents, discover extensionless Lance datasets, and improve Warehouse compact JSON tree / folder catalog UI (#121).chronicle.manifestsidecars for cheap nested discovery and compact-jsonl stats; explorer uses leaf counts with read-side roll-up and pages large manifesto-backed sources instead of expandingpath_index.pchronicle serve --catalog-configmounts all[datasets.*]entries; addserve catalog dataset add|remove|list.AWS_REGION/ endpoint / keys) before the Tokio runtime; s3:// aliases without--regionfall back to documentedus-west-2.Test plan
just test persisting-pchroniclejust test persisting-pchronicle-clicargo fmt --all -- --checkid/ with JSON documents; export preserves original bytespchronicle serve --listen 127.0.0.1:6001 --catalog-config ./tmp/catalog.tomlwith MinIO and no inheritedAWS_*pchronicle ls @rfsagainst an s3 alias with endpoint/keys but no stored regionunreachableSupersedes #121.