ECHO-883 polish: past-tense monitor event names, swap funnel tooltip colors#854
Merged
Conversation
…ltip Rename two server analytics events to match the snake_case past-tense convention: server_chunk_not_found_in_s3 -> server_chunk_missing_in_s3, server_chunk_upload_bad -> server_chunk_upload_rejected. Update the confirm_chunk_upload analytics test to match. Swap the funnel tooltip's hardcoded bg-slate-800/text-white for brand tokens (bg-graphite/text-parchment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename two server analytics events to match the snake_case past-tense
convention: server_chunk_not_found_in_s3 -> server_chunk_missing_in_s3,
server_chunk_upload_bad -> server_chunk_upload_rejected. Update the
confirm_chunk_upload analytics test to match.
Swap the funnel tooltip's hardcoded bg-slate-800/text-white for brand
tokens (bg-graphite/text-parchment).