Skip to content

ECHO-883 polish: past-tense monitor event names, swap funnel tooltip colors #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ussaama merged 1 commit into from
Jul 16, 2026
Merged

ECHO-883 polish: past-tense monitor event names, swap funnel tooltip colors #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion echo/frontend/src/components/conversation/FunnelCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export const FunnelCanvas = ({
/>
{hover && (
<div
className="pointer-events-none absolute z-10 -translate-x-1/2 -translate-y-full rounded bg-slate-800 px-2 py-1 text-xs text-white shadow"
className="pointer-events-none absolute z-10 -translate-x-1/2 -translate-y-full rounded bg-graphite px-2 py-1 text-xs text-parchment shadow"
style={{ left: hover.x, top: hover.y - 6 }}
>
{hover.label}
Expand Down
4 changes: 2 additions & 2 deletions echo/server/dembrane/api/participant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ async def confirm_chunk_upload(
)
await capture_event(
conversation_id,
"server_chunk_not_found_in_s3",
"server_chunk_missing_in_s3",
{"chunk_id": body.chunk_id},
)
raise HTTPException(
Expand Down Expand Up @@ -844,7 +844,7 @@ async def confirm_chunk_upload(
)
await capture_event(
conversation_id,
"server_chunk_upload_bad",
"server_chunk_upload_rejected",
{"chunk_id": body.chunk_id, "file_size": file_size},
)
# Update the returned chunk to include the error
Expand Down
6 changes: 3 additions & 3 deletions echo/server/tests/api/test_confirm_chunk_upload_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Tests for the server_chunk_upload_bad and server_chunk_not_found_in_s3
"""Tests for the server_chunk_upload_rejected and server_chunk_missing_in_s3
captures in confirm_chunk_upload."""

from __future__ import annotations
Expand Down Expand Up @@ -44,7 +44,7 @@ async def test_confirm_upload_captures_bad_chunk_when_too_small() -> None:

capture.assert_any_await(
"conv-1",
"server_chunk_upload_bad",
"server_chunk_upload_rejected",
{"chunk_id": "chunk-1", "file_size": 512},
)

Expand All @@ -69,6 +69,6 @@ async def test_confirm_upload_captures_s3_not_found_after_retries() -> None:
assert exc_info.value.status_code == 400
capture.assert_any_await(
"conv-1",
"server_chunk_not_found_in_s3",
"server_chunk_missing_in_s3",
{"chunk_id": "chunk-1"},
)
Loading