Skip to content

parametermanager: add data_crc32c to google_parameter_manager_parameter_version - #18940

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-559022023
Sep 10, 2026
Merged

parametermanager: add data_crc32c to google_parameter_manager_parameter_version#18940
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-559022023

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Added field coverage for payload.dataCrc32c on google_parameter_manager_parameter_version (parametermanager:v1:ParameterVersion).

reference: b/559022023

parametermanager: added `data_crc32c` field to `google_parameter_manager_parameter_version`

@modular-magician

modular-magician commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 833e534:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 147 insertions(+), 1 deletion(-)
google-beta provider View Diff 6 files changed, 147 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 111 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
54 51 0 3
Affected Service Packages
  • parametermanager
  • parametermanagerregional

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccParameterManagerParameterVersion_dataCrc32c
  • TestAccParameterManagerParameterVersion_parameterVersionWithDataCrc32cExample
  • TestAccParameterManagerParameterVersion_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccParameterManagerParameterVersion_dataCrc32c
✅ Log TestAccParameterManagerParameterVersion_parameterVersionWithDataCrc32cExample
✅ Log TestAccParameterManagerParameterVersion_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 833e534!

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from ScottSuarez September 9, 2026 23:51
@modular-magician

modular-magician commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e6eecd9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 147 insertions(+), 1 deletion(-)
google-beta provider View Diff 6 files changed, 147 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 111 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
54 54 0 0
Affected Service Packages
  • parametermanagerregional
  • parametermanager

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick, @ScottSuarez VCR tests complete for e6eecd9!

@slevenick
slevenick added this pull request to the merge queue Sep 10, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b2513d5 Sep 10, 2026
30 checks passed
@slevenick
slevenick deleted the mm-b-559022023 branch September 10, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants