fix(snapshot): refuse receipt paths that escape the handed directory - #515
Merged
kstonekuan merged 1 commit intoSep 13, 2026
Merged
Conversation
Reuse storage._validated_relative_key so verify_dataset_snapshot raises (exit 2) before reading absolute or .. paths, matching the documented join-only-onto-the-handed-root promise (Hebbian-Robotics#469).
kstonekuan
approved these changes
Sep 13, 2026
kstonekuan
left a comment
Contributor
There was a problem hiding this comment.
LGTM, merging.
Reusing _validated_relative_key is the right call: the verifier and storage roots now give one answer to "is this key inside the root".
Checked it against the three shapes from the issue plus the ones that must still pass:
../outside/secret.bin REFUSE
/etc/hostname REFUSE
tables/../../outside/secret.bin REFUSE
C:\Windows\x REFUSE
samples.parquet accept, unchanged
assets/wrist_cam/frame_01.jpg accept, unchanged
It normalizes ./a and a//b, which our exporter never writes and which does not reach the digest (_inventory_content_id hashes record.path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_dataset_snapshotreuses_validated_relative_keyand raises (CLI exit 2) before reading absolute /../ drive-letter receipt paths.Test plan
../, absolute path, andtables/../../…(subdir present) → exit 2tests/test_snapshot_verify.py+tests/test_dataset_snapshot.py