Skip to content

fix(transform): preserve declared empty camera channels - #534

Closed
harshitethic wants to merge 1 commit into
Hebbian-Robotics:mainfrom
harshitethic:fix/preserve-empty-camera-channel
Closed

harshitethic wants to merge 1 commit into
Hebbian-Robotics:mainfrom
harshitethic:fix/preserve-empty-camera-channel

Conversation

@harshitethic

Copy link
Copy Markdown
Contributor

Summary

  • preserve declared-but-empty compressed-image camera channels during canonicalization instead of dropping them
  • register those channels as empty canonical foxglove.CompressedVideo channels so the source declaration remains part of provenance and content identity
  • keep the existing behavior that ffmpeg is not resolved or stamped as used when no camera payload was actually transcoded
  • add a regression test proving an empty camera declaration survives the transform and produces a different content-addressed episode from an otherwise identical source without that declaration

Verification

  • git diff --check
  • uv run ruff check src/hflow/transform.py tests/test_processing_regressions.py
  • uv run pytest -q tests/test_processing_regressions.py -k empty_camera

Fixes #528

@github-actions

Copy link
Copy Markdown

👋 Hi @harshitethic — thanks for the contribution! To keep starter issues available
for other contributors and give every pull request a real review, we accept
1 open pull request per contributor at a time.

You already have #531 open, so this one is being closed automatically.
Once your open pull request is merged or closed, feel free to reopen this one —
no work is lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: transform: declared-but-empty camera channel is dropped, merging distinct sources and erasing provenance

1 participant