fix: add parameterized queries in import-legacy.ts - #285
Open
anupamme wants to merge 1 commit into
Open
Conversation
The import-legacy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
snell-panel/scripts/import-legacy.ts.Vulnerability
V-001snell-panel/scripts/import-legacy.ts:27Description: The import-legacy.ts script constructs SQL INSERT statements using string concatenation with values derived from external API responses. The script fetches data from a user-provided URL and directly interpolates the response data into SQL statements without parameterization. While a simple quote-escaping function (s()) is used, it is insufficient protection against all SQL injection techniques.
Evidence
Exploitation scenario: An attacker who controls the legacy panel API or can perform a man-in-the-middle attack on the connection can inject malicious SQL payloads through any string field (node_id, node_name, psk,.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Changes
snell-panel/scripts/import-legacy.tsBehavior Preservation
The change is scoped to 1 file on the vulnerable path.
Automated security fix by OrbisAI Security