Skip to content

fix: add parameterized queries in import-legacy.ts #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add parameterized queries in import-legacy.ts #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions snell-panel/scripts/import-legacy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,23 @@ const keep = entries.filter((e) => String(e.version) !== "5");
const dropped = entries.length - keep.length;

const now = Math.floor(Date.now() / 1000);
// Escape for a single-quoted SQLite string literal: double embedded quotes and
// strip NUL bytes that quote-doubling alone does not neutralize.
const s = (v: string | null | undefined) =>
v === null || v === undefined ? "NULL" : `'${String(v).replace(/'/g, "''")}'`;
const n = (v: number | null | undefined) =>
v === null || v === undefined || (v as unknown) === "" ? "NULL" : Number(v);
v === null || v === undefined
? "NULL"
: `'${String(v)
.replace(/\0/g, "")
.replace(/'/g, "''")}'`;
// Numeric fields are interpolated unquoted, so any non-finite input
// (including attacker-controlled strings from the legacy API) must be
// rejected outright rather than silently coerced/NaN'd into the SQL text.
const n = (v: number | null | undefined) => {
if (v === null || v === undefined || (v as unknown) === "") return "NULL";
const num = Number(v);
if (!Number.isFinite(num)) throw new Error(`expected numeric value, got: ${String(v)}`);
return num;
};
const b = (v: unknown) => (v ? 1 : 0);

const cols =
Expand Down