Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .buildkite/downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ steps:
- label: "CUDA.jl"
plugins:
- JuliaCI/julia#v1:
version: "1.12"
version: "1.13"
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
Expand Down Expand Up @@ -42,7 +42,7 @@ steps:
- label: "oneAPI.jl"
plugins:
- JuliaCI/julia#v1:
version: "1.12"
version: "1.13"
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
Expand Down Expand Up @@ -75,7 +75,7 @@ steps:
- label: "AMDGPU.jl"
plugins:
- JuliaCI/julia#v1:
version: "1.12"
version: "1.13"
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
Expand Down Expand Up @@ -104,7 +104,7 @@ steps:
- label: "Metal.jl"
plugins:
- JuliaCI/julia#v1:
version: "1.12"
version: "1.13"
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
Expand Down Expand Up @@ -144,7 +144,7 @@ steps:
- label: "OpenCL.jl"
plugins:
- JuliaCI/julia#v1:
version: "1.12"
version: "1.13"
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/GetAsserts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
strategy:
fail-fast: false
matrix:
# NOTE: 'master' is currently disabled; keep in sync with TestAsserts
version: ['1.12', '1.13']
# keep in sync with TestAsserts
version: ['1.12', '1.13', 'master']
build: ['x86_64-linux-gnuassert']
steps:
# Only checks out the base branch (never PR code)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['1.10', '1.11', '1.12', '1.13-nightly', 'nightly']
version: ['1.10', '1.11', '1.12', '1.13', 'nightly']
os: [ubuntu-24.04, ubuntu-24.04-arm, macOS-15, windows-2025]
llvm_args: ['']
include:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/TestAsserts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
with:
script: |
// Keep in sync with the matrix below
const versions = ['1.12', '1.13'];
const versions = ['1.12', '1.13', 'master'];
await Promise.all(versions.map(version =>
github.rest.checks.create({
owner: context.repo.owner,
Expand All @@ -55,7 +55,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['1.12', '1.13']
version: ['1.12', '1.13', 'master']
steps:
- name: Download Julia build
uses: actions/download-artifact@v8
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
with:
script: |
// Keep in sync with the matrix above
const versions = ['1.12', '1.13'];
const versions = ['1.12', '1.13', 'master'];
const jobs = await github.paginate(github.rest.actions.listJobsForWorkflowRunAttempt, {
owner: context.repo.owner,
repo: context.repo.repo,
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
with:
script: |
// Keep in sync with the matrix above
const versions = ['1.12', '1.13'];
const versions = ['1.12', '1.13', 'master'];
await Promise.all(versions.map(version =>
github.rest.checks.create({
owner: context.repo.owner,
Expand Down
9 changes: 6 additions & 3 deletions src/optim.jl
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,12 @@ function (self::LowerGCFrame)(fun::LLVM.Function)
@compiler_assert isempty(uses(alloc_obj)) self.job
end

# we don't care about write barriers
if haskey(functions(mod), "julia.write_barrier")
barrier = functions(mod)["julia.write_barrier"]
# we don't care about write barriers. Julia 1.14 replaced `julia.write_barrier` with
# object and field-aware variants, the latter specialized on the slot address space.
for name in ("julia.write_barrier", "julia.object_write_barrier",
"julia.field_write_barrier.p11", "julia.field_write_barrier.p13")
haskey(functions(mod), name) || continue
barrier = functions(mod)[name]

for use in uses(barrier)
call = user(use)::LLVM.CallInst
Expand Down
19 changes: 19 additions & 0 deletions test/ptx.jl
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,25 @@ end
@check_not "gpu_gc_pool_alloc"
PTX.code_native(mod.ref_kernel, Tuple{Ptr{Int64}, Int})
end

# storing a heap object into a field of another one emits a write barrier
# (split into object and field-aware variants on Julia 1.14)
mod = @eval module $(gensym())
mutable struct Outer
x::Any
end

function store_field(outer, inner)
outer.x = inner
nothing
end
end

@test @filecheck begin
@check_label "define void @{{(julia|j)_store_field_[0-9]+}}"
@check_not "write_barrier"
PTX.code_llvm(mod.store_field, Tuple{mod.Outer, Base.RefValue{Int}})
end
end

@testset "float boxes" begin
Expand Down
Loading