Julia 1.14 compatibility: field-aware write barriers; CI on 1.13 and master asserts - #956
Merged
Merged
Conversation
Julia 1.13 has been released, so test on it instead of the 1.13 nightly, and run the back-end tests on it. Also re-enable testing against assert builds of Julia master, which are available again from the julia-ci pipeline, to catch issues with the upcoming 1.14 early. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
- Coverage 86.54% 85.55% -1.00%
==========================================
Files 29 29
Lines 5729 5800 +71
==========================================
+ Hits 4958 4962 +4
- Misses 771 838 +67 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maleadt
marked this pull request as ready for review
September 25, 2026 13:22
JuliaLang/julia#62737 replaced `julia.write_barrier` with `julia.object_write_barrier` and `julia.field_write_barrier.p11/.p13`. Only the former was removed by GPULowerGCFrame, so the new intrinsics survived into device code whenever an object was stored into a field, e.g. when constructing a LazyString in an error path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maleadt
changed the title
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
julia.write_barrierintojulia.object_write_barrierandjulia.field_write_barrier.p11/.p13. GPULowerGCFrame only removed the old intrinsic, so the new ones leaked into device code whenever a heap object was stored into a field. This broke e.g. CUDA.jl'srandn!onComplexF16, via theLazyStringinsincospi's error path. Adds a PTX test that fails without the fix. The existing tests missed it becausecode_nativedoesn't validate IR.1.13instead of1.13-nightly, and use 1.13 for the downstream back-end tests (was 1.12). Re-enablemasterin the assert-build workflows: julia-ci publishes master assert builds again, and LLVM.jl already uses them. GetAsserts runs aspull_request_target, so this PR can't exercise that change. I ran the suite against the master assert build (1.14.0-DEV.3363, julia-ci build 666) on x86_64 Linux instead, and it passes.