Create shared swapchains fixes#1908
Merged
charles-lunarg merged 2 commits intoMay 31, 2026
Merged
Conversation
There was a backwards check for ICD surfaces in vkCreateSharedSwapchainsKHR, causing it to always fail if it was called with surface handles that had been used before. The correct version of this check now lives in the helper function wsi_unwrap_icd_surface(), so remove this broken and redundant one.
The test was creating two swapchains and storing the result in a non-array result variable.
|
Author cubanismo not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author cubanismo not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 751578. |
|
CI Vulkan-Loader build # 3493 running. |
|
CI Vulkan-Loader build # 3493 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a backwards check for ICD surfaces in vkCreateSharedSwapchainsKHR, causing it to always fail if it was called with surface handles that had been used before. The correct version of this check now lives in the helper function wsi_unwrap_icd_surface(), so remove this broken and redundant one.
While I was there, I noticed an overflow in vkCreateSharedSwapchainsKHR. The test was creating two swapchains and storing the result in a non-array result variable.