Skip to content

Create shared swapchains fixes #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charles-lunarg merged 2 commits into from
May 31, 2026
+4 −7
Merged

Create shared swapchains fixes #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31ce3d
fix: vkCreateSharedSwapchains stale bad list check
cubanismo May 31, 2026
ed6c67c
tests: Fix overflow in vkCreateSharedSwapchainsKHR
cubanismo May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions loader/wsi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2207,12 +2207,6 @@ VKAPI_ATTR VkResult VKAPI_CALL terminator_CreateSharedSwapchainsKHR(VkDevice dev
"[VUID-vkCreateSharedSwapchainsKHR-device-parameter]");
abort(); /* Intentionally fail so user can correct issue. */
}
if (NULL != icd_term->surface_list.list) {
loader_log(NULL, VULKAN_LOADER_ERROR_BIT, 0,
"vkCreateSharedSwapchainsKHR Terminator: No VkSurfaceKHR objects were created, indicating an application "
"bug. Returning VK_SUCCESS. ");
return VK_SUCCESS;
}
if (NULL == dev->loader_dispatch.extension_terminator_dispatch.CreateSharedSwapchainsKHR) {
loader_log(NULL, VULKAN_LOADER_ERROR_BIT, 0,
"vkCreateSharedSwapchainsKHR Terminator: Driver's function pointer was NULL, returning VK_SUCCESS. Was the "
Expand Down
5 changes: 4 additions & 1 deletion tests/loader_get_proc_addr_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,10 @@ TEST(GetDeviceProcAddr, SwapchainFuncsWithTerminator) {
infos[1].sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;
infos[1].surface = surface2;

ASSERT_EQ(VK_SUCCESS, CreateSharedSwapchainsKHR(dev.dev, 2, infos.data(), nullptr, &swapchain));
std::array<VkSwapchainKHR, 2> swapchains{};
ASSERT_EQ(VK_SUCCESS, CreateSharedSwapchainsKHR(dev.dev, static_cast<uint32_t>(swapchains.size()), infos.data(), nullptr,
swapchains.data()));
ASSERT_FALSE(log.find("vkCreateSharedSwapchainsKHR Terminator: No VkSurfaceKHR objects were created"));
}
env.vulkan_functions.vkDestroySurfaceKHR(inst.inst, surface, nullptr);
env.vulkan_functions.vkDestroySurfaceKHR(inst.inst, surface2, nullptr);
Expand Down
Loading