Co-locate Claude review checklists with their skills#1370
Open
labkey-martyp wants to merge 1 commit intodevelopfrom
Open
Co-locate Claude review checklists with their skills#1370labkey-martyp wants to merge 1 commit intodevelopfrom
labkey-martyp wants to merge 1 commit intodevelopfrom
Conversation
The .agents/ directory only existed to host review-checklist files referenced by two .claude/skills/ skills (code-review-jest and code-review-react). Each skill.md reached across the tree via ../../../.agents/review-checklists/..., which is more fragile and less self-contained than the established skill pattern (e.g. wcag-compliance keeps its checklist next to its skill.md). Co-locate the rule files with their skills, and factor the shared reviewer-priority and review-format guidance into a single file at .claude/skills/review-priority-and-format.md (renamed from common.md to describe its contents). * Move jest checklists from .agents/review-checklists/jest/ into .claude/skills/code-review-jest/. * Move react checklists from .agents/review-checklists/react/ into .claude/skills/code-review-react/. * Promote shared guidance to .claude/skills/review-priority-and-format.md; both code-review skills now reference it via ../review-priority-and-format.md. * Update the Prerequisite link at the top of each rule file to the new shared path -- these had been dangling after the move. * Remove the now-empty .agents/ directory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
.agents/directory predates LabKey standardizing on Claude Code as its main AI toolset, and was only being used to host review-checklist files referenced by two.claude/skills/skills. Co-locate the rule files with their skills and consolidate the shared guidance under.claude/skills/.Related Pull Requests
Changes
.claude/skills/code-review-jest/and.claude/skills/code-review-react/respectively..claude/skills/review-priority-and-format.md(renamed fromcommon.md); both code-review skills reference it via../review-priority-and-format.md..agents/directory./code-review-jestand/code-review-reactto confirm both skills resolve their Checklist links.