Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Business Logic

> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
## Jest tests must assert on meaningful outcomes

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Code Quality

> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
## Arrange / Act / Assert (AAA) structure

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Performance

> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
## No redundant or near-duplicate tests

Expand Down
2 changes: 1 addition & 1 deletion .claude/skills/code-review-jest/skill.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Use this skill whenever the user asks to review Jest test code (especially `.tes
Stick to the checklist below for every applicable file and mode. Apply only the Jest checklist rules to test files — do not apply React component rules to component code that happens to be visible via imports in the test file.

## Checklist
See [.agents/review-checklists/common.md](../../../.agents/review-checklists/common.md) for reviewer priority and standard review format, and [.agents/review-checklists/jest/code-quality.md](../../../.agents/review-checklists/jest/code-quality.md), [.agents/review-checklists/jest/performance.md](../../../.agents/review-checklists/jest/performance.md), [.agents/review-checklists/jest/business-logic.md](../../../.agents/review-checklists/jest/business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.
See [review-priority-and-format.md](../review-priority-and-format.md) for reviewer priority and standard review format, and [code-quality.md](code-quality.md), [performance.md](performance.md), [business-logic.md](business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.

Use the rule's `Urgency` to place findings in the "urgent issues" vs "suggestions" sections.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Rule Catalog — Business Logic

> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
## Avoid using array index as React key

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Rule Catalog — Code Quality

> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
## Props interface should be declared separately

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Rule Catalog — Performance

> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
## Inline object/array literals in JSX props

Expand Down
2 changes: 1 addition & 1 deletion .claude/skills/code-review-react/skill.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Use this skill whenever the user asks to review frontend code (especially `.tsx`
Stick to the checklist below for every applicable file and mode. Apply only the React/frontend checklist rules — do not apply Jest test rules to test code that may be co-located or visible in the same file.

## Checklist
See [.agents/review-checklists/common.md](../../../.agents/review-checklists/common.md) for reviewer priority and standard review format, and [.agents/review-checklists/react/code-quality.md](../../../.agents/review-checklists/react/code-quality.md), [.agents/review-checklists/react/performance.md](../../../.agents/review-checklists/react/performance.md), [.agents/review-checklists/react/business-logic.md](../../../.agents/review-checklists/react/business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.
See [review-priority-and-format.md](../review-priority-and-format.md) for reviewer priority and standard review format, and [code-quality.md](code-quality.md), [performance.md](performance.md), [business-logic.md](business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.

Additionally, check for WCAG 2.2 Level AA accessibility violations using [wcag-22-checklist.md](../wcag-compliance/wcag-22-checklist.md). Use category **Accessibility** for these findings. Prioritize urgent WCAG criteria (missing alt text, keyboard traps, no focus indicators, missing form labels, broken ARIA) alongside Correctness-level issues.

Expand Down
Loading