Skip to content

fix: Classify Capped Artifact Probe Candidates - #206

Merged
danny-avila merged 1 commit into
mainfrom
danny-avila/fix-artifact-cap-probe
Sep 14, 2026
Merged

danny-avila merged 1 commit into
mainfrom
danny-avila/fix-artifact-cap-probe

Conversation

@danny-avila

Copy link
Copy Markdown
Collaborator

I fixed the output-cap probe so artifacts that are ineligible for collection retain their normal truncation classification instead of being mislabeled as max-files omissions. This closes #205.

  • Validate supported artifact paths before treating them as hidden by the output-file cap.
  • Stat cap-probe candidates and classify oversized files as size truncations.
  • Preserve bounded hashing and unchanged inline-entrypoint/session suppression behavior.
  • Add regression coverage for oversized and overlong supported files after the output cap is full.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Ran the focused walker suite: 59 passed.
  • Ran the complete API suite with the host-only AWS_CA_BUNDLE variable removed: 434 passed, 16 skipped, 0 failed.
  • Ran git diff --check.

Checklist

  • My code adheres to this project style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head d9951f8. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T19:42:03.713464Z d9951f8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danny-avila danny-avila changed the title 🧭 fix: Classify Capped Artifact Probe Candidates fix: Classify Capped Artifact Probe Candidates Sep 14, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: d9951f8be7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 3e7b107 into main Sep 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifact cap probe misclassifies oversized or invalid-path files as max_files

1 participant