[feature/capgen-v1-cleanup-01] Make constituent index lookup routines case insensitive#766
Merged
climbfuji merged 5 commits intoJul 10, 2026
Conversation
Collaborator
|
Thanks for creating this PR. I'll test it and update the PR description accordingly. |
climbfuji
changed the title
climbfuji
changed the title
climbfuji
approved these changes
Jul 10, 2026
climbfuji
left a comment
climbfuji
left a comment
Collaborator
There was a problem hiding this comment.
Works like a charm, thank you!
I'll merge this right away, because it's for the feature/capgen-v1-cleanup-01 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the same as #765, but for branch
feature/capgen-v1-cleanup-01.Adds
to_lowerroutine tocapgen/src/ccpp_constituent_prop_mod.F90and uses that to make theccpp_constituent_index,ccpp_constituent_indices, and<host>_const_get_indexinterfaces case insensitive.User interface changes?: No
Testing: 2 small mods to check case insensitivity in end-to-end advection test.