fix(ci): push each image of a multi-image subtree to its own dev repository - #1985
balajinvda wants to merge 1 commit into
Conversation
…sitory image-push mapped every target named `image` to the service repository. NVCA has four such targets, cmd/nvca, cmd/nvca-operator, cmd/cluster-validator and cmd/tools, so a deploy-to-stg build pushed all four to <registry>/nvca:<tag> and the last one won. When a subtree has more than one plain `image` target, the package leaf now names the repository, with the leaf equal to the service keeping the service name. Subtrees with a single `image` target keep mapping to the service wherever that target lives. Co-Authored-By: Balaji Ganesan <bganesan@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/nvcf/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe manual image-push workflow now counts plain ChangesImage repository naming
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains from the reviewed change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Why
The
deploy-to-stgbuild on #1969 reported success but pushed all four NVCA images to the same place:The repository name is derived from the target name, and a target named
imagemaps to the service. NVCA has four targets namedimagein differentcmd/packages, so the last push won and the dev tag is unusable for the agent or the operator.What changed
When a subtree has more than one plain
imagetarget, the package leaf names the repository, and the leaf that equals the service keeps the plain service name. A subtree with a singleimagetarget keeps mapping to the service wherever that target lives. Simulated against everyimagetarget in the tree: NVCA becomesnvca,nvca-operator,cluster-validator,tools; the two Rust stargate crates becomepylonandstargateif that subtree is ever pushed; every other service is unchanged.Customer Release Notes
Not customer visible
Plan Summary
Not applicable
Usage
Label a PR
deploy-to-stgas before. NVCA builds now land in the four repositories above under the samegh.<run>-<sha>tag.Testing
actionlinton the workflow: clean. YAML parses.imagetargets in the tree, see above.deploy-to-stgbuild on fix(nvca): storage capability catalog reaches the agent, with Weka and OCI FSS enabled #1969 after this merges.Notes
CI-only change, no tests to add. The
tagsattribute on the NVCA image targets already carries the intended names; a follow-up could derive from it, but the package leaf matches production naming for the two that matter.References
None
Related Pull Requests
Dependencies
None
Issues
Relates to #1326
Summary by CodeRabbit