Skip to content

fix(ci): push each image of a multi-image subtree to its own dev repository #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balajinvda wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): push each image of a multi-image subtree to its own dev repository #1985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/workflows/image-push-manual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,18 @@ jobs:
exit 1
fi
echo "discovered: ${indexes[*]}"
# A subtree with several targets all named `image` (nvca: cmd/nvca,
# cmd/nvca-operator, cmd/cluster-validator, cmd/tools) would map every
# one of them to the service repo and the last push would win. When
# that is the case, the package leaf names the repo instead, with the
# leaf that equals the service keeping the plain service name. A
# subtree with a single `image` target keeps mapping to the service
# wherever that target lives (cmd/, crates/server/, ...).
plain_image_count=0
for tgt in "${indexes[@]}"; do
n="${tgt##*:}"; n="${n%_index}"
[ "$n" = "image" ] && plain_image_count=$((plain_image_count + 1))
done
for tgt in "${indexes[@]}"; do
name="${tgt##*:}"; name="${name%_index}"
# Two naming conventions exist in the tree and they mean different
Expand All @@ -342,7 +354,13 @@ jobs:
# Previously the hyphenated form fell through to the default and
# produced names like byoo-otel-collector-byoo-otel-collector-image.
case "$name" in
image) repo="${svc}" ;;
image)
if [ "$plain_image_count" -gt 1 ]; then
pkg="${tgt%%:*}"; leaf="${pkg##*/}"
if [ "$leaf" = "$svc" ]; then repo="${svc}"; else repo="${leaf}"; fi
else
repo="${svc}"
fi ;;
*_image) sub="$(printf '%s' "${name%_image}" | tr '_' '-')"; repo="${svc}-${sub}" ;;
*-image) repo="${name%-image}" ;;
*) sub="$(printf '%s' "$name" | tr '_' '-')"; repo="${svc}-${sub}" ;;
Expand Down
Loading