Preserve group types and whitespace boundaries in trajectory tensorization - #904
Merged
Merged
Conversation
bradhilton
changed the base branch from
hayek/preserve-nan-logprobs-json
to
main
September 16, 2026 03:26
bradhilton
force-pushed
the
hayek/text-equivalent-prompt-masks
branch
from
September 16, 2026 03:26
76d327f to
2283a7c
Compare
bradhilton
marked this pull request as ready for review
September 16, 2026 03:30
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conventional multi-history training currently needs a cast after
group.tensorize(), and some saved Qwen histories fail tokenization when the server and chat template encode identical whitespace differently.TokenizedTrajectoryGroup.tensorize()that preserve the single-history or multi-history trajectory type. Runtime tensorization is unchanged; callers can access.historieswithout a cast.The whitespace failure occurs when a length-stopped Qwen response forces rendering of a history whose prompt encoded two newlines as one token, while the renderer uses two tokens straddling the assistant-prefix boundary. Both fixes support Caladan experiment 056. This PR builds on the merged #903. Rebasing onto its squash merge preserved the incremental patch byte-for-byte.
Validation
assert_typechecks cover both group overloads, and Caladan's training loop type-checks without a cast.git diff --checkpassed.