Skip SAM3 lab_sim objectives pending the port migration - #836
Merged
griswaldbrooks merged 1 commit intoAug 8, 2026
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe integration test skip set now includes two objectives that indirectly use removed per-model path ports. Comments record that PR ChangesObjective integration test updates
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
|
griswaldbrooks
deleted the
fm/skip-sam3-objectives-pending-port-migration
branch
August 8, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Temporarily skips the two
lab_simintegration objectives that reachGetMasks2DFromExemplar. Its four per-model path ports (encoder_model_path,text_encoder_model_path,geometry_encoder_model_path,decoder_model_path) are replaced bymodel_bundle_manifest+runtime_idin moveit_pro#21155, so these objectives cannot load against that image while they still set the removed ports.ML Segment Bottles from File— sets the removed ports directly.Pick 1 Pill Bottle with SAM3— reaches them indirectly viaGet Bottle Grasp via ICP Subtree→Segment Bottle Subtree.The skip is temporary. #802 performs the port swap and re-enables both.
Scope checked:
ML Find Bottles on Table from Image Exemplaris already skipped, and every other SAM3 objective inlab_sim,hangar_sim,kitchen_sim,dual_arm_sim, andfactory_simis markedrunnable="false", so it is already excluded from integration runs — which is why onlylab_simfailed. No other coverage is affected and nothing else is in this diff.