Skip to content

Skip SAM3 lab_sim objectives pending the port migration - #836

Merged
griswaldbrooks merged 1 commit into
mainfrom
fm/skip-sam3-objectives-pending-port-migration
Aug 8, 2026
Merged

Skip SAM3 lab_sim objectives pending the port migration#836
griswaldbrooks merged 1 commit into
mainfrom
fm/skip-sam3-objectives-pending-port-migration

Conversation

@griswaldbrooks

Copy link
Copy Markdown

[written by AI]

Temporarily skips the two lab_sim integration objectives that reach GetMasks2DFromExemplar. Its four per-model path ports (encoder_model_path, text_encoder_model_path, geometry_encoder_model_path, decoder_model_path) are replaced by model_bundle_manifest + runtime_id in moveit_pro#21155, so these objectives cannot load against that image while they still set the removed ports.

  • ML Segment Bottles from File — sets the removed ports directly.
  • Pick 1 Pill Bottle with SAM3 — reaches them indirectly via Get Bottle Grasp via ICP SubtreeSegment Bottle Subtree.

The skip is temporary. #802 performs the port swap and re-enables both.

Scope checked: ML Find Bottles on Table from Image Exemplar is already skipped, and every other SAM3 objective in lab_sim, hangar_sim, kitchen_sim, dual_arm_sim, and factory_sim is marked runnable="false", so it is already excluded from integration runs — which is why only lab_sim failed. No other coverage is affected and nothing else is in this diff.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c0bf6c26-e460-4589-b2f5-d442c93090d1

📥 Commits

Reviewing files that changed from the base of the PR and between f9f967b and f5221df.

📒 Files selected for processing (1)
  • src/lab_sim/test/objectives_integration_test.py

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated integration test coverage to skip two objectives that depend on obsolete model-path ports.
    • Documented that these objectives can be re-enabled after the related functionality is restored.

Walkthrough

The integration test skip set now includes two objectives that indirectly use removed per-model path ports. Comments record that PR #802 re-enables these objectives.

Changes

Objective integration test updates

Layer / File(s) Summary
Skip objectives with removed model-path ports
src/lab_sim/test/objectives_integration_test.py
The skip set includes ML Segment Bottles from File and Pick 1 Pill Bottle with SAM3. Comments document their dependency on removed model-path ports and re-enablement by PR #802.

Possibly related PRs

Suggested reviewers: shaur-k

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains why two lab_sim integration objectives are temporarily skipped and identifies the planned re-enablement.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Human Review Check ✅ Passed The commit changes only one lab_sim integration-test skip set, with two entries and comments; it does not modify production code, APIs, auth, infrastructure, launch scripts, or behavior packages.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

@griswaldbrooks
griswaldbrooks merged commit ba0ffca into main Aug 8, 2026
16 checks passed
@griswaldbrooks
griswaldbrooks deleted the fm/skip-sam3-objectives-pending-port-migration branch August 8, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant