Fail closed when primary VF lookup is Err or missing - #15
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
VF Err and a missing result key were collapsed to visibility_reason None. Hydrator Err is skipped by update_all, so VFFilter treated both as Allow. Stamp UnspecifiedReason so the filter drops, matching XaiVfClient missing ids. Successful Ok(None) Allow is unchanged. Rebased onto xai-org/x-algorithm main. Keep upstream's combined result map and in_network_ids dedup. Following hydrator uses the same resolve path. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/vf-primary-miss-fail-closed-1c99
branch
from
September 7, 2026 04:14
1e33e66 to
3644090
Compare
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:31
|
Superseded. Do not merge this PR. This branch is the same head as upstream xai-org#121 ( Clean fork twin, based on latest Pitchfork Upstream xai-org#121 is untouched and should stay on that branch. Do not force-push or rewrite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VFCandidateHydratorturns a primary VFError a missing result key intovisibility_reason = None.VFFilterkeepsNone.Some(Err)used to return hydratorErr.Hydrator::update_allskips that write, so the candidate keeps the defaultNoneand still serves. A missing map key was written asNonedirectly.Ok(None)is a successful Allow. That path is unchanged.This is not xai-org#119 (retweet primary looked up by wrapper id). This is not xai-org#117 (QuoteHydrator TES / socialgraph). This is not label or TES-flag miss work.
VFCandidateHydrator::resolve_visibility(Following uses the same function)VFFilter::should_drop(None => false)XaiVfClient::results_to_mapalready writesUnspecifiedReasonfor a missing response id. The hydrator was throwing that away onErrand on Strato keys that never come back.Fix
Stamp
FilteredReason::UnspecifiedReasonon primaryErrand missing key soupdate_allwrites it andVFFilterdrops (Some(_) => true). Same sentinel the Xai VF client already uses.Ancillary
Err/ missing key now setdrop_ancillary_postsso a quote, reply, or retweet whose child was not evaluated is also dropped. Successful ancillary Allow (Ok(None)) is unchanged. Interstitial on a child is still not treated as Drop (leftover).Rebased onto latest
xai-org/x-algorithmmain. Kept upstream's combined result map andin_network_idsdedup.VFFollowingCandidateHydratornow calls the sameresolve_visibilityso Latest Following is also fail-closed.Tests
ErrstampsUnspecifiedReason(no longer hydratorErr)UnspecifiedReasonOk(None)staysNone(Allow)Err/ missing key drop; ancillary Allow does notVFFilterdropsUnspecifiedReasonand still keepsNonecargo testcannot run. Public dump has no Home Mixer manifest.Leftover
Quote / retweet / ancestor
Action::Interstitialstill does not setdrop_ancillary_posts. Wrapper can survive a soft verdict on the child. Separate from lookup miss.Upstream: xai-org#121