Fail closed when primary VF lookup is Err or missing - #26
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Stamp UnspecifiedReason on primary VF Err/missing key so VFFilter drops. Ancillary Err/missing now sets drop_ancillary_posts. Ok(None) Allow is unchanged. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:49
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#121. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
Pitchfork-and-Torch
deleted the
cursor/vf-primary-miss-fail-closed-fork15-9313
branch
September 18, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VFCandidateHydratorturns a primary VFError a missing result key intovisibility_reason = None.VFFilterkeepsNone.Some(Err)used to return hydratorErr.Hydrator::update_allskips that write, so the candidate keeps the defaultNoneand still serves. A missing map key was written asNonedirectly.Ok(None)is a successful Allow. That path is unchanged.This is the clean Pitchfork-main twin of upstream xai-org#121. It supersedes dirty fork #15, which reused the upstream branch and showed 297-file conflicts.
This is not a retweet-wrapper-id lookup bug. This is not QuoteHydrator TES / socialgraph. This is not label or TES-flag miss work.
VFCandidateHydrator::resolve_visibilityVFFilter::should_drop(None => false)XaiVfClient::results_to_mapalready writesUnspecifiedReasonfor a missing response id. The hydrator was throwing that away onErrand on Strato keys that never come back.Fix
Stamp
FilteredReason::UnspecifiedReasonon primaryErrand missing key soupdate_allwrites it andVFFilterdrops (Some(_) => true). Same sentinel the Xai VF client already uses.Ancillary
Err/ missing key now setdrop_ancillary_postsso a quote, reply, or retweet whose child was not evaluated is also dropped. Successful ancillary Allow (Ok(None)) is unchanged. Interstitial on a child is still not treated as Drop (leftover).Ported onto latest Pitchfork
main, including the existing per-safety-levelVfVerdictsmaps.VFFollowingCandidateHydratoris not on this tree, so it is not in this PR.Tests
ErrstampsUnspecifiedReason(no longer hydratorErr)UnspecifiedReasonOk(None)staysNone(Allow)Errand omitted id both stamp; Allow does notErr/ missing key drop; ancillary Allow does notVFFilterdropsUnspecifiedReasonand still keepsNonecargo testcannot run. Public dump has no Home Mixer manifest.Leftover
Quote / retweet / ancestor
Action::Interstitialstill does not setdrop_ancillary_posts. Wrapper can survive a soft verdict on the child. Separate from lookup miss.Upstream: xai-org#121
Supersedes: #15